feat(splunk_hec source): Support custom extractors#25180
Open
20agbekodo wants to merge 9 commits intovectordotdev:masterfrom
Open
Conversation
Add `type Config: Send + Sync + Clone` to the `Extractor` trait so that wrapper implementations (e.g. OPW's splunk_hec_opw) can receive per-source config data (such as a token-to-attribute mapping) at extractor construction time without relying on global state. - `DefaultExtractor` uses `type Config = ()` — no behaviour change - `SplunkSource<E>` stores `extractor_config: E::Config` and clones it into the warp closure for each request - Add `SplunkSource::new_from_parts` public constructor for use by wrapper source implementations that don't have a `SplunkConfig` - Re-export `HecAcknowledgementsConfig` from the `splunk_hec` module
62c1a5c to
af94a00
Compare
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the complete version of this one which implements custom extractors for the SplunkHEC source.
Explanation
From the first PR
Extractorwas created and added as a generic parameter toSplunkSourceDefaultExtractors used in theEventIteratorwere grouped under a singleDefaultExtractortype implementingExtractorand provided as the default type for the splunk source generic (the originalDefaultExtractortype was renamedMetaExtractor)Extractortrait provides a constructor which is called when instantiating theEventIterator, passing aRequestMetaobject containing information about the request being processed (splunk token, remote address)SplunkConfiginto alistenmethod so that the SplunkSource can be easily initialized in a different contextSplunkSourceimpl which did not depend on the SplunkSource struct (options,required_channel,lenient_json_content_type_check) were moved to plain functions to avoid the need for calling them withSplunkSource::<DefaultExtractor>::options()Added on top of that
Add
type Config: Send + Sync + Cloneto theExtractortrait so thatwrapper implementations (e.g. OPW's splunk_hec_opw) can receive
per-source config data (such as a token-to-attribute mapping) at
extractor construction time without relying on global state.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.