[WIP-DON'T MERGE YET] update pattern deletion logic #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dminnear-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dminnear-rh
force-pushed
the
pattern-delete
branch
from
83788a6 to
9aab6c0
Compare
Contributor
|
/recheck |
Contributor
|
/lgtm |
Contributor
|
/recheck |
1 similar comment
Contributor
|
/recheck |
dminnear-rh
changed the title
dminnear-rh
force-pushed
the
pattern-delete
branch
from
9aab6c0 to
c04e182
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
dminnear-rh
force-pushed
the
pattern-delete
branch
from
c04e182 to
8ff052c
Compare
this commit includes two key changes: 1. A sync with prune is triggered to remove all applications part of the pattern BEFORE the subscriptions and other resources are deleted to prevent applications from becoming undeleteable if CRs, webhooks, etc disappear. 2. Subscription for openshift-gitops is no longer owned by pattern instances. Previously, deleting a pattern would delete this subscription and a new subscription would not be able to be created on the reinstall of a pattern since the CSV still existed. The subscription is necessary since it sets the env var ARGOCD_CLUSTER_CONFIG_NAMESPACES to '*'. Without the subscription the ArgoCD instance created by the new pattern would be created in namespaced mode and many charts like vault will not install since they try to create clusterwide resources like clusterrolebindings
… to determine if sync is in progress during finalization of pattern
This is needed for the pattern operator to be able to fetch the resources from spoke clusters via open-cluster-management search-api.
Remove dead code bits, and return true only if there is actually managed clusters other than the local-cluster
Remove dead code bits, and return true only if there is actually managed clusters other than the local-cluster
Cleanup, add deletion phases to cover proper ordering
We only sync now with prune if its a must
dminnear-rh
force-pushed
the
pattern-delete
branch
from
ce76df7 to
9efac33
Compare
Contributor
|
@dminnear-rh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit includes two key changes: