Conversation
- Migrates project from Unity 2020.3.11f1 to 2022.3.62f3; updates Packages/manifest.json and ProjectSettings accordingly - Adds .devcontainer/ with devcontainer.json, setup.sh, and get-license.sh for Codespaces and local Docker development with Unity license activation - Adds Assets/Editor/DevContainerSetup.cs for generating .csproj/.sln IntelliSense files via Unity batch mode (using 2022.3 API) - Updates .gitignore to exclude Logs/, UserSettings/, .vscode/; removes those directories from tracking - Fixes IndexOutOfRangeException in GenerateInterior() by clamping cell.x to valid chosencells bounds (was resolution-dependent crash) - Defers initial Generate() call by one frame so Camera.aspect is settled before map dimensions are computed, fixing map not filling screen on first load
hushed archives now links to the archive generator instead of friends of jak
I reread the faction entry and realized my mistake :)
Open
Author
|
This should resolve #3, but a second verification can't hurt @bughunterstudios. I've only built and run this locally, I am not sure what additional steps are needed to post an updated build to itch.io. |
Gulluth
commented
May 23, 2026
| map_chars = null; | ||
|
|
||
| // Wait one frame so the camera aspect ratio reflects the final Game window size. | ||
| yield return null; |
Gulluth
commented
May 23, 2026
| cell = new Vector2Int(Mathf.RoundToInt(cell_x), Random.Range(0, available_height / cellsize)); | ||
| cell = new Vector2Int( | ||
| Mathf.Clamp(Mathf.RoundToInt(cell_x), 0, (width / cellsize) - 1), | ||
| Random.Range(0, available_height / cellsize)); |
Author
There was a problem hiding this comment.
This fixes a map generation crash that causes the map to not load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the 404 errors with the SRD urls after SRD updates
I didn't want to have to install Unity, so I attempted to add a devcontainer. The project was based on Unity 2020.3 LTS and upstream provides this version in an earlier Ubuntu LTS release which doesn't support devcontainers. Instead of hacking the earlier version of Ubuntu to support devcontainers, it was easier to update VaarnAtlas to Unity 2022.3 LTS which uses a newer Ubuntu release with devcontainer support.
In the end I did have to install Unity Hub locally, but I kept the devcontainer support so future work will be easier. Updating the LTS Unity also extends bugfix updates to the Unity engine for 2 more years. Easy choice.