Skip to content

vere64#970

Open
matthew-levan wants to merge 199 commits intodevelopfrom
ml/64
Open

vere64#970
matthew-levan wants to merge 199 commits intodevelopfrom
ml/64

Conversation

@matthew-levan
Copy link
Copy Markdown
Contributor

@matthew-levan matthew-levan commented Feb 23, 2026 •
edited
Loading

Cribbed from #794.

This PR introduces 64-bit Vere. c3_w is now either 32 or 64 bit, depending on if it was compiled with -DVERE64 (on by default, or off with zig build -Dvere32).

The following work still needs to be done:

  • define final typedefs, update usages accordingly
  • every appearance of _tmp in pkg/noun (excluding pkg/noun/jets) (~800 locations)
    • trace.{c,h}
    • ship.{c,h}
    • nock.h
    • version.h
    • imprison.{c,h}
    • jets.{c,h}
    • allocate.{c,h}
    • retrieve.{c,h}
    • *_tests.c
  • every appearance of _tmp in pkg/noun/jets
  • look at diff of pre and post VERE64 compilation with -Wconversion flag. Investigate every instance.
  • run with llvm addr sanitizer, ubsan
  • audit every jet
  • migrations: bidirectional (use MSB of version tag to mark if vere64 or not? maybe also add metadata for pointer compression)
  • integrate Joe's page based allocator
  • new rsignal_setjmp/longjmp may have volatility problems (talk to Joe. maybe use atomics?)
  • pkg/vere/noun-tests is completely broken
    • ensure noun tests make sense/are worth having
  • every appearance of _tmp in any other subdirectory (~1000 locations)
  • c3_w_clz, ctz, pc occurrences (we should change current occurrences to _tmp as we did with u3r_word, etc and go through them
  • c3_etch_word, c3_sift_word occurrences (also change to _tmp)
  • make sure everything works (C tests and hoon tests included) still for vere32
  • revendor murmur3 with a size_t len
  • test really big nouns in ames/fine/mesa
  • the event log and other lmdb state should not need migration. we should double check lmdb.c, disk.c
  • there's a lot of bloq size related things in the jets that could be changed to greater than 32 for the 32 bit case
  • (mug .(eny 0, now 0)) equality test for fakezods booted in 32-bit and 64-bit modes
  • mug-verified automated migration tests in ci

ziffee and others added 30 commits March 5, 2025 17:36
v64: start c3_w_tmp replace
b28d000
remove bad files
2e49c49
newlines
ad1b921
parens
f6be93e
start c3_n transition
cdb8f74
further
02320d6
word(s) -> word(s)_tmp
aeb8907
all noun tests working
947bd10
many fixes
d1b3836
start mean changes
045654b
some regex
31b22f8
phew
0a41c1f
more
263fccd
fix mul64 for vere32 case, add build.zig
e87c444
rename _bytes_log -> _bytes_shift
96e640f
@barter-simsum
migrations 1-4
5e62165
@barter-simsum
0: hashtable.[c|h] c3_w_tmp -> c3_w_new | c3_n
9f66047
@barter-simsum
1: hashtable.[c|h] c3_w_tmp -> c3_w_new | c3_n
4b0dd1e
@barter-simsum
2: hashtable.[c|h] c3_w_tmp -> c3_w_new | c3_n
5f9436e
@barter-simsum
events.c _tmp -> new, and misc loom version changes
94c3d7a
@barter-simsum
vortext.[c|h] c3_w_tmp -> c3_n
d6d0dd0
@barter-simsum
0: trace.[c|h] c3_w_tmp -> c3_w_new | c3_n
860f396
@barter-simsum
1: trace.[c|h] c3_w_tmp -> c3_w_new | c3_n
fce4af5
@barter-simsum
I'll squash the below commits later
b0aa442
@barter-simsum
build.zig TODOs
b94a13d
@barter-simsum
options.h c3_w_tmp -> c3_n
e72be53
zif/64: merge next/kelvin-409
d2f5cfa
zif/64: merge jb/palloc
61fc9de
@matthew-levan
Merge commit 'e3f19ab9253c79823a80c9aaf9aa9275b05ca33a' into msl/zif/64
02d5cfb
@matthew-levan
Merge branch 'next/kelvin/409' into msl/zif/64
d230f0b
dozreg-toplud
dozreg-toplud reviewed Mar 1, 2026
View reviewed changes
dozreg-toplud
dozreg-toplud reviewed Mar 1, 2026
View reviewed changes
dozreg-toplud
dozreg-toplud reviewed Mar 1, 2026
View reviewed changes
dozreg-toplud and others added 16 commits March 31, 2026 17:24
@dozreg-toplud
add casts in callsites of variadic functions
64ed829
@matthew-levan
add casts in callsites of variadic functions (#988)
445d8ac
@dozreg-toplud
better variadic u3r/x_mean
3e2f187
@dozreg-toplud
change calls to u3r/x_mean
019229f
@dozreg-toplud
better u3m_grab
f2a3977
@dozreg-toplud
change calls to u3m_grab
b6fb577
@dozreg-toplud
u3i_molt better variadic
4d58875
@dozreg-toplud
u3i_list better variadic
849298f
@dozreg-toplud
remove missed u3i_list terminators
4c86385
@dozreg-toplud
simpler variadic macros
2bd8cda
@dozreg-toplud
array type namespacing
0b63268
@dozreg-toplud
variadic functions: comments
3627b26
@dozreg-toplud
variadic functions: don't eval args twice
67023b3
@matthew-levan
better variadic functions (#990)
7aeb65a 
`va` stuff appears to be error-prone and hard to debug when it comes to
vere64 rewrite. One missing cast is enough to cause input argument
corruption.

This PR changes most of our variadic functions to functions that take an
array and a `c3_z` length + a variadic macro wrapper.

I target vere64 because the change mostly concerns that branch, to make
@matthew-levan life simpler when it comes to merges.
@matthew-levan
noun: refactor 32-bit <-> 64-bit migration to use pam_d, define `u3…
8fd251a 
…a_wits` (word bits)
@matthew-levan
Merge branch 'develop' into ml/64
2933f2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mopfel-winrux mopfel-winrux mopfel-winrux left review comments

@dozreg-toplud dozreg-toplud dozreg-toplud left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthew-levan @mopfel-winrux @dozreg-toplud @barter-simsum