New flow changes [supersedes #100] - #110
Draft
craftxbox wants to merge 15 commits into
Draft
Conversation
…s not exist on a request
craftxbox
marked this pull request as draft
August 9, 2026 07:17
corp-0
reviewed
Aug 9, 2026
| connection_challenge = serializers.CharField(min_length=128, max_length=128) | ||
|
|
||
| class AuthRequestSerializer(ConnectionChallengeSerializer): | ||
| #previously used to be allow_blank but blank seems to get interpreted as not being present, which causes |
Member
There was a problem hiding this comment.
the documented behavior for allow_blank is considering an empty string as valid, but the field should always be present. What did you find it was doing instead?
Author
There was a problem hiding this comment.
I genuinely do not remember, i will have to come back to that. i tHINK it was treating an empty string as null and violating the non_null constraint but i cannot remember.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than continuing on a diverged branch I decided to take what I have and target develop.
This PR implements the connection challenge and redemption aspects of the new auth flow, as well as work on the scope token system.
Closes #100