Skip to content

Fix/setup and template fixes#48

Open
twhlynch wants to merge 8 commits intouberpixel:developfrom
twhlynch:fix/setup-and-template-fixes
Open

Fix/setup and template fixes#48
twhlynch wants to merge 8 commits intouberpixel:developfrom
twhlynch:fix/setup-and-template-fixes

Conversation

@twhlynch
Copy link
Contributor

remove unneeded offset of vr camera position
with the -1.8 offset on the vr camera it would be under the map. now it is correctly with ground level at the ground. non vr camera still starts in the ground, as it did previously. id guess the -1.8 thing used to be needed but now its unneeded.

explicitely use python3 in regenerate script for compatability
some systems map python to python2, and some dont have it at all. generally its expected that python3 will exist so it should be used in unix scripts (https://peps.python.org/pep-0394/)

fix issues breaking compiling

  • bump std to c++20 which is required for rayne
  • enable UI to fix FlexUI not compiling

update xcode signing identity and remove hardcoded id

  • "Apple Development" is the current only option for signing certs
  • i removed the hardcoded id and just left it with a placeholder. this should be fine as the behaviour of the first build prompting it to be set stays, and someone using the template can hardcode their own id if needed.

refactor CreateProject script
made slightly more readable and added __TMP_BUNDLE_DOMAIN__ which would be like 'com.slindev'

remove hardcoded bundle domain and add to CreateProject script
com.slindev was hardcoded, now it uses the above mentioned __TMP_BUNDLE_DOMAIN__

modernise gitignore
editor configs, lsp output, comments

clean up cmakelists making use of cmake variables

  • reduces the amount of __TMP__ variables by using cmakes ${PROJECT_NAME} variable and setting variables at the start like LIBRARY_NAME and BUNDLE_ID
  • GRAB was hardcoded in around $<TARGET_FILE_DIR:GRAB> $<TARGET_RUNTIME_DLLS:GRAB>
  • merged some set_target_properties for readability
  • replaced setting a compile definitions variable per OS with directly calling target_compile_definitions. it seemed to be that way so it could accumulate definitions easier, but target_compile_definitions accumulates by default so that was redundant

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the base-vr project template and project generator tooling to improve out-of-box build compatibility and remove template hardcoding (VR camera offset, Python invocation, CMake template cleanup, and signing/bundle-id templating).

Changes:

  • Switch template regeneration script to explicitly use python3.
  • Adjust VR camera reset position to remove the -1.8 Y offset.
  • Refactor the base-vr template CMakeLists (C++20, UI module enabled, reduced __TMP__ usage, signing/bundle-id placeholders) and modernize template .gitignore.
  • Refactor CreateProject.py and introduce __TMP_BUNDLE_DOMAIN__ replacement derived from bundle id.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Tools/ProjectGenerator/Templates/base-vr/regenerate-project.sh Use python3 for cross-system compatibility.
Tools/ProjectGenerator/Templates/base-vr/Sources/__TMP__CameraManager.cpp Remove VR camera Y offset on reset.
Tools/ProjectGenerator/Templates/base-vr/CMakeLists.txt Template build fixes/refactors: C++20, UI module ON, variable cleanup, updated signing placeholders.
Tools/ProjectGenerator/Templates/base-vr/.gitignore Add common editor/LSP/build/cache ignores and reorganize entries.
Tools/ProjectGenerator/CreateProject.py Refactor variable handling and add __TMP_BUNDLE_DOMAIN__ generation/replacement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@twhlynch
Copy link
Contributor Author

this guy sucks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants