Java fork of Bazel 8.1.1#29
Open
justinwon777 wants to merge 6 commits intouber-common:release-8.1.1from
Open
Conversation
Release Notes:
Some lite binaries experienced issues with graceful shutdown. This was due to the runscript not calling exec on $JAVABIN if the classpath was too large and Bazel had to create a manifest jar. In this commit, we update this line to call exec, allowing for signals to be propagated to the java process correctly.
During the creation of a fat jar, several files on the classpath can have the same name. In some situations, these files should be merged together. In this commit, we add Concatenators for every file under META-INF/spring except spring.factories, so that these files are merged together. spring.factories is excluded because it needs special processing. This is a properties file, so it needs to be properly merged - if several spring.factories have the same key, and the files are simply concatenated, only one instance of the key will win. Instead, the values from each file need to be merged together under one key. This commit also implementes a sublcass of Concatenator called the MergingPropertyCombiner. This combiner will handle the file in the way described above. We also instantiate a MergingPropertyCombiner for spring.factories so that the files are properly merged, allowing the spring application to begin. Additionally, we add a Concatenator for META-INF/cxf/bus-extensions.txt, which is needed for the same reasons as the spring.factories files.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked the java commits from the 7.6.1 fork.
Built //src:java_tools_prebuilt.zip, //src:java_tools.zip, and //src:bazel successfully