core: add project-wide default inputs - #313
Merged
Merged
Conversation
tingerrr
requested changes
Aug 25, 2026
tingerrr
left a comment
tingerrr
left a comment
Member
There was a problem hiding this comment.
Looks good, I've left a few comments, but nothing major.
T1mVo
force-pushed
the
project-wide-inputs
branch
2 times, most recently
from
August 25, 2026 20:14
a6de0c9 to
6593a8f
Compare
Allow configuring default `sys.inputs` key-value pairs in `[tool.tytanic.default]` via a new `inputs` table. These defaults are exposed to every unit test, and values from a test's `input` annotation override any project default with the same key.
T1mVo
force-pushed
the
project-wide-inputs
branch
from
August 25, 2026 20:19
6593a8f to
081230f
Compare
tingerrr
requested changes
Aug 26, 2026
tingerrr
left a comment
tingerrr
left a comment
Member
There was a problem hiding this comment.
Once the test files are persisted this can be merged.
T1mVo
force-pushed
the
project-wide-inputs
branch
2 times, most recently
from
August 26, 2026 15:27
180f0e7 to
7ca09d5
Compare
T1mVo
force-pushed
the
project-wide-inputs
branch
from
August 26, 2026 15:29
7ca09d5 to
ae58a6e
Compare
Member
|
I don't know why I trust GitHub to work at this point, some updates to the other migration tests were missing and because the CI wasn't even run it broke the tests on main. Note that this is neither problematic in terms of actual functionality, nor your fault, but Io felt like saying it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See commit messages.
Related Issues
Closes #312
Checklist