Skip to content

chore: fix clippy::question-mark lint in execute_effects - #189

Open
shsw228 wants to merge 1 commit into
typester:mainfrom
shsw228:fix/clippy-question-mark
Open

chore: fix clippy::question-mark lint in execute_effects#189
shsw228 wants to merge 1 commit into
typester:mainfrom
shsw228:fix/clippy-question-mark

Conversation

@shsw228

@shsw228 shsw228 commented Aug 22, 2026

Copy link
Copy Markdown

The Lint job currently fails on main with a single pre-existing
clippy::question-mark error in yashiki/src/app/effects.rs. This replaces the
match with ?, which also matches the neighbouring Effect::ExecCommand arm.

Behaviour is unchanged: exec_command_tracked and execute_effects both use
String as the error type, so ? propagates exactly as return Err(e) did.

Verified with the CI commands: cargo test --all (310 passed),
cargo fmt --all --check, cargo clippy --all -- -D warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant