Skip to content

Fix various runtime metrics issues - #160

Merged
iRevive merged 3 commits into
typelevel:mainfrom
vlovgr:runtime-metrics-fixes
Sep 25, 2026
Merged

iRevive merged 3 commits into
typelevel:mainfrom
vlovgr:runtime-metrics-fixes

Conversation

@vlovgr

@vlovgr vlovgr commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Three separate issues discovered while setting up dashboards.

  • d651367 The jvm.gc.duration was reported in milliseconds instead of seconds because:
    MillisPerSecond = TimeUnit.MILLISECONDS.toNanos(1) = 1000000L
    
    instead of the expected milliseconds per seconds.
    MillisPerSecond = TimeUnit.SECONDS.toMillis(1) = 1000L
    
  • 5dffacc The jvm.class.count (classes currently loaded) and jvm.class.loaded (classes loaded since start) were accidentally swapped.
  • 1e7a587 For scalanative.gc.duration the accumulated collection time was recorded with every refresh (and reported in milliseconds, similar to the first issue). We now record every collection since the previous refresh, counting the average duration (in seconds) of the collections in the refresh period.

@iRevive iRevive left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iRevive
iRevive merged commit 85d891a into typelevel:main Sep 25, 2026
10 checks passed
@vlovgr
vlovgr deleted the runtime-metrics-fixes branch September 25, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants