re-roll lockfile, fixing the floating deps tests#1575
Closed
NullVoxPopuli wants to merge 1 commit intomasterfrom
Closed
re-roll lockfile, fixing the floating deps tests#1575NullVoxPopuli wants to merge 1 commit intomasterfrom
NullVoxPopuli wants to merge 1 commit intomasterfrom
Conversation
NullVoxPopuli
added
dependencies
Collaborator
Author
|
Just kidding, looks like this has to be rolled up in to: #1574 |
Collaborator
Author
|
trashing this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floating tests have been failing, but in order to fix them, some dependency changes needed to occur.
This started in a few other PRs, but I found that this was the minimal changeset I could generate while still getting things working not-worse than
maintoday.