Conversation
GustavoDCC
force-pushed
the
fix/models
branch
from
0772ffc to
b9b329b
Compare
GustavoDCC
force-pushed
the
fix/models
branch
from
b9b329b to
14ef102
Compare
PetervDooren
left a comment
PetervDooren
left a comment
There was a problem hiding this comment.
For the most part I am going to assume this was tested.
One question on how we should go about making the tutorial and one remark for the future.
|
Revert all HERO changes |
Review commits separately Used to generate tue-robotics/ed_tutorials#10
GustavoDCC
force-pushed
the
fix/models
branch
from
1ec22a8 to
6c2635f
Compare
This reverts commit dc09f33. Use an open source robot model
MatthijsBurgh
left a comment
MatthijsBurgh
left a comment
There was a problem hiding this comment.
Some changes need an explanation of @GustavoDCC
|
Please review and approve @GustavoDCC @PetervDooren |
PetervDooren
left a comment
PetervDooren
left a comment
There was a problem hiding this comment.
What is the purpose of these changes? Because I don't see these as strict improvements. We add a bunch of sdf files without adding instructions to the tutorial.
I remember a few of the plugin configs were out of date, making the tutorials not work. But there are a lot more changes here than just those.
Please elaborate a bit on why these changes were necessary.
|
|
||
| ```bash | ||
| export ED_MODEL_PATH=`pwd`/my-model-dir | ||
| source ../setup_env.bash # This needs to be done from the tutorial specific folder |
There was a problem hiding this comment.
This part still does not fully explain what needs to happen to set the model paths. It instead gives the user a magic bash script that does everything for them.
Write down in the tutorial what paths need to be set. With the sdf models this also includes Gazebo_model_path and gazebo_resource_path
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" ?> | |||
There was a problem hiding this comment.
The tutorial instructs the user to make a yaml file. Now there is both a yaml file for a table and an sdf file. I dont know which one ED will take here but this is definitly bad practice.
The tutorial also does not mention how to create an sdf file. If you want to update the models you should also update the tutorial itself.
3 participants
No description provided.