fix: add SSRF protection and enable TLS verification in URI source#313
Open
Joshua-Medvinsky wants to merge 1 commit into
Open
fix: add SSRF protection and enable TLS verification in URI source#313Joshua-Medvinsky wants to merge 1 commit into
Joshua-Medvinsky wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the LLMStack Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The URI data source passes user-controlled URLs directly to
requests.head()andrequests.get()withverify=False, enabling SSRF attacks against internal services and cloud metadata endpoints, as well as MITM attacks on outbound connections.Fix
_is_private_url()validation function that blocks URLs pointing to private/internal IP ranges (RFC 1918, loopback, link-local, reserved) and known metadata hostnames.verify=Falsetoverify=Trueinget_url_content_type().ValueErrorwhen a private URL is detected.Test Plan
Security Note
Severity: High — SSRF allows access to internal services and cloud metadata (AWS/GCP/Azure credentials). Disabled TLS verification enables MITM attacks.