Skip to content

Support getting variant from versioned bundle#1026

Merged
trunk-io[bot] merged 2 commits intomainfrom
christian/support-getting-variant-from-versioned-bundle
Feb 5, 2026
Merged

Support getting variant from versioned bundle#1026
trunk-io[bot] merged 2 commits intomainfrom
christian/support-getting-variant-from-versioned-bundle

Conversation

@cmillar-trunk
Copy link
Collaborator

In support of TRUNK-17480, we need to get the variant from the versioned bundle. We could put it in trunk2, but that would be an unpleasant surprise to deal with when upgrading the analytics_cli_bundle lib, which should be a rote thing to do.

In support of TRUNK-17480, we need to get the variant from the versioned
bundle. We could put it in trunk2, but that would be an unpleasant
surprise to deal with when upgrading the analytics_cli_bundle lib, which
should be a rote thing to do.
@trunk-io
Copy link

trunk-io bot commented Feb 4, 2026

😎 Merged directly without going through the merge queue, as the queue was empty and the PR was up to date with the target branch - details.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.61%. Comparing base (72aad86) to head (a1c9b5f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bundle/src/bundle_meta.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
+ Coverage   81.40%   81.61%   +0.21%     
==========================================
  Files          69       69              
  Lines       14527    14537      +10     
==========================================
+ Hits        11825    11864      +39     
+ Misses       2702     2673      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-staging-io
Copy link

trunk-staging-io bot commented Feb 4, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io trunk-io bot merged commit a5c0dbf into main Feb 5, 2026
25 checks passed
@trunk-io
Copy link

trunk-io bot commented Feb 5, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants