build: bump kwil-db to pick up the p2p and statesync fixes - #1428
Conversation
Time Submission Status
Submit or update total time with: Add time on top of previous submission with: See available commands to help comply with our Guidelines. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR updates the pinned ChangesKwil DB Dependency Update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This dependency-only update has no identified unresolved risk and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@holdex pr submit-time 2h |
The node has pinned
kwil-dbatc7425a52since 19-Jun. Nine commits have landed on kwil-db main since then, including every peer-to-peer and statesync fix from the last two weeks, and none of them is in a node binary. This moves the pin tocf061288.What it carries
admin peerslists a connected peer that has no dialable addressTwo things worth knowing before the release
The erc20 meta-schema gains an index, and it is built at startup. #1715 adds
idx_balances_reward_balanceand bumps the meta-schema version from 2 to 3, which is what makesOnStartre-run the idempotentcreateSchemaon an existing node. Without that version bump the index would never reach a database that already exists. The index is built with a plainCREATE INDEX IF NOT EXISTSduring startup, so the first start on the new version pays for it once, in proportion to the size ofbalances.The postgres change is not in this bump. #1714 raises
work_mem, and it editscontrib/docker/postgres.dockerfilerather than any Go file. It reaches an operator through a new postgres image, not through this dependency. Worth saying out loud so nobody reads the commit list and assumes otherwise.Consensus
Nothing here changes execution. The one commit that touches SQL generation, #1716, replaces
HasSuffixplusTrimSuffixwithCutSuffixon both branches and produces the same string, so generated SQL is byte-identical. The rest is peer-to-peer, statesync, an admin RPC listing, and an index.Verification
go build ./...andgo vet -tags kwiltest ./...are clean.tests/streams/auth(185s),tests/streams/aggregation(147s) andtests/streams/query(467s). That is the part a dependency bump most needs to prove, since it is the engine underneath every action.go.moddiff is the twokwil-dblines and nothing else;go mod tidypulled in no transitive changes.There is no Problem issue behind this. It is the delivery step for work already merged in kwil-db, so it carries no closing keyword.
Summary by CodeRabbit