feat(approval-flow): treat issue closure as denial#209
Open
snskArora wants to merge 3 commits intotrstringer:mainfrom
Open
feat(approval-flow): treat issue closure as denial#209snskArora wants to merge 3 commits intotrstringer:mainfrom
snskArora wants to merge 3 commits intotrstringer:mainfrom
Conversation
lizziemac
approved these changes
Apr 13, 2026
Collaborator
lizziemac
left a comment
lizziemac
left a comment
There was a problem hiding this comment.
Looks good to me - had one thought but I'm fine with you merging if you don't think it's necessary (it's been a while since I've been in this repo and your knowledge is fresher)
| close(channel) | ||
| case approvalStatusPending: | ||
| if apprv.closeIssueMeansDenial { | ||
| issue, _, err := client.Issues.Get( |
Collaborator
There was a problem hiding this comment.
I wonder if we should only call this every X loops to reduce API calls
granted it's only when closeIssueMeansDenial is set, but worth considering
lizziemac
reviewed
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #199
Testing workflows:
testing the existing workflow (backward compatibility, default behaviour)
https://github.com/snskArora/sandbox/actions/runs/24009833832/job/70019520102
Manual approval required for workflow run 24009833832 snskArora/sandbox#35
Closing the issue doesnt have any effect if the variable
close-issue-means-denialis missingtesting issue closure denies the workflow or not
close-issue-means-denial: trueset in action inputshttps://github.com/snskArora/sandbox/actions/runs/24009867780/job/70019646047
Manual approval required for workflow run 24009867780 snskArora/sandbox#37
testing fail-on-denial with this functionality
fail-on-denial: false&close-issue-means-denial: trueset in action inputshttps://github.com/snskArora/sandbox/actions/runs/24009899588/job/70019720817
Manual approval required for workflow run 24009899588 snskArora/sandbox#39