Skip to content

fix: https://github.com/triton-inference-server/server/issues/8537 #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksn7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: https://github.com/triton-inference-server/server/issues/8537 #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pb_stub.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,10 +936,13 @@ Stub::RunCoroutine(py::object coroutine, bool in_background)
py::object py_future = py::module_::import("asyncio").attr(
"run_coroutine_threadsafe")(coroutine, loop);
if (in_background) {
// We should add the future to background_futures_ before attaching a
// done callback to avoid the issue described here:
// https://github.com/triton-inference-server/server/issues/8537
background_futures_.attr("add")(py_future);
py_future.attr("add_done_callback")(
py::module_::import("c_python_backend_utils")
.attr("async_event_future_done_callback"));
background_futures_.attr("add")(py_future);
return py::none();
}
return py_future.attr("result")();
Expand Down