chore(webapp): integration settings copy update - #4850
Conversation
…toggle The config file setting says the path is auto-detected by default, the pre-build command description carries an example, and the "Use native build server" switch is only rendered for admins — GitHub deployments use the native build server unless an admin opts a project out. When the switch is hidden the stored value is submitted through a hidden input, since an absent field would read as an opt-out on save.
…ve-build in the header
…admins only A non-admin save now carries the stored disableNativeBuildServer forward instead of trusting the submitted field, so a crafted POST or a stale tab cannot flip the setting. The client-side hidden input is no longer needed.
|
|
Preview Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (35)
🧰 Additional context used📓 Path-based instructions (7)For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md) Files:
**Prefer static imports over dynamic imports.** Only use dynamic `import()` when:📄 CodeRabbit inference engine (AGENTS.md) Files:
Add crumbs as you write code — not just when debugging. Mark lines with📄 CodeRabbit inference engine (AGENTS.md) Files:
Use zod for validation in packages/core and apps/webapp📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Access environment variables through the `env` export of `env.server.ts` instead of directly accessing `process.env`📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc) Files:
Use function declarations instead of default exports📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
Use types over interfaces for TypeScript📄 CodeRabbit inference engine (.github/copilot-instructions.md) Files:
🔇 Additional comments (1)
WalkthroughThe integration settings action preserves the stored native build server opt-out for non-admin, non-impersonating users. Admins and impersonating users can still change the setting. The form displays the native build server toggle only to users with admin access. Related descriptions, CLI documentation, and command placeholders were updated. GitHub app and repository status rows now display status labels before success icons. Merge Risk: 🔵 Low · up to The admin-only native build-server setting is protected for direct submissions, but a concurrent non-admin settings save can overwrite a newer administrator change with stale data. This is limited to the affected project and requires timing overlap, so the PR is mergeable with explicit owner awareness or follow-up to make the protected update atomic. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
3 participants
Project → Settings → Integrations, build settings for GitHub deploys: