Skip to content

feat(webapp): polish the org Projects settings page - #4828

Merged
samejr merged 1 commit into
mainfrom
samejr/davis
Aug 29, 2026
Merged

feat(webapp): polish the org Projects settings page#4828
samejr merged 1 commit into
mainfrom
samejr/davis

Conversation

@samejr

@samejr samejr commented Aug 29, 2026

Copy link
Copy Markdown
Member

Changelog

Polish for the organization Projects settings page:

  • Evened out the right padding on the side-menu runtime-update dot so it sits with equal spacing on all sides.
  • Added a warning-orange dot beside the Runtime update available heading.
  • The update heading now leads with the count, e.g. "5 projects to update", in warning-orange.
  • The bottom section is renamed All projects and now lists every project, not just the up-to-date ones.
  • When nothing needs updating, an "All projects are up to date" status shows at the top of the list.
  • Minor copy/style tweaks: lowercased "production" and shrank the inline config code one size.

All accent colors use the existing warning/success design tokens.

CleanShot 2026-08-29 at 10 20 28 CleanShot 2026-08-29 at 10 39 34

Open workspace in Conductor

- Even out the side-menu runtime-update dot's right padding
- Add a warning dot beside the "Runtime update available" heading
- Show the count in the orange "N projects to update" heading
- List every project under "All projects" (not just up-to-date ones)
- Add an "All projects are up to date" status when nothing needs updating
- Lowercase "production" and shrink the inline config code

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2f1fa23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8da6d0d1-20cd-4283-9167-3c85daa408d6

📥 Commits

Reviewing files that changed from the base of the PR and between f8aacac and 2f1fa23.

📒 Files selected for processing (2)
  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (7)
For dashboard changes, visually verify the running Remix app with Chrome DevTools MCP, using snapshots, screenshots, interaction, and console-message checks as appropriate.

📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)

Files:

  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx
**Prefer static imports over dynamic imports.** Only use dynamic `import()` when:

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx
Add crumbs as you write code — not just when debugging. Mark lines with

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx
Use zod for validation in packages/core and apps/webapp

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx
Access environment variables through the `env` export of `env.server.ts` instead of directly accessing `process.env`

📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)

Files:

  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx
Use function declarations instead of default exports

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx
Use types over interfaces for TypeScript

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx
🧠 Learnings (1)
📚 Learning: 2026-08-21T09:19:47.298Z
Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 4749
File: apps/webapp/app/components/primitives/Switch.tsx:11-14
Timestamp: 2026-08-21T09:19:47.298Z
Learning: Do not request `// crumbs` markers, `#region crumbs` blocks, or agentcrumbs imports for presentational React component changes, such as Tailwind class-only updates, when there is no runtime logic, data flow, or value requiring tracing. These are temporary debugging instrumentation and are not required for every diff.

Applied to files:

  • apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx
🔇 Additional comments (2)
apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.projects/ProjectsPage.tsx (1)

16-16: LGTM!

Also applies to: 56-59, 72-80, 89-94, 122-128, 141-168

apps/webapp/app/components/navigation/OrganizationSettingsSideMenu.tsx (1)

144-145: LGTM!


Walkthrough

The projects settings page now combines projects needing runtime updates with other projects in a name-sorted “All projects” list. It displays update counts, warning and success status indicators, revised guidance text, and simplified empty-state copy. The navigation Projects badge dot now includes additional right spacing.

Merge Risk: ⚪ Minimal · up to 2f1fa

This change only polishes the organization Projects settings page and updates how existing project status information is displayed. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description provides a relevant changelog and screenshots, but it omits the required issue reference, checklist, and testing sections. Add a Closes #<issue> reference, complete the checklist, and describe the testing steps used to verify the change.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: polishing the organization Projects settings page.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch samejr/davis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@samejr
samejr merged commit 6a87048 into main Aug 29, 2026
59 checks passed
@samejr
samejr deleted the samejr/davis branch August 29, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants