refactor: rename the local_bundle build path value to native_local_bundle

Author: myftija

apps/webapp/app/v3/deploymentTelemetry.ts

@@ -28,7 +28,7 @@ export const DeploymentTelemetryAttributes = {
   STATUS: "deployment.status",
   // status === DEPLOYED; CANCELED is excluded from failure rates
   SUCCESS: "deployment.success",
-  // depot / native / local_bundle (see deriveBuildPath)
+  // depot / native / native_local_bundle (see deriveBuildPath)
   BUILD_PATH: "deployment.build_path",
   // V1 / MANAGED (run engine)
   WORKER_TYPE: "deployment.worker_type",
@@ -55,7 +55,7 @@ export const DeploymentTelemetryAttributes = {
   DURATION_DEPLOYING_MS: "deployment.duration.deploying_ms",
 } as const;
 
-export type DeploymentBuildPath = "local_bundle" | "native" | "depot";
+export type DeploymentBuildPath = "native_local_bundle" | "native" | "depot";
 
 /**
  * Everything that is not a native-build-server deployment falls into the depot
@@ -67,7 +67,7 @@ export function deriveBuildPath(buildServerMetadata: unknown): DeploymentBuildPa
   const metadata = BuildServerMetadata.safeParse(buildServerMetadata);
 
   if (metadata.success && metadata.data.isNativeBuild) {
-    return metadata.data.fromBundle ? "local_bundle" : "native";
+    return metadata.data.fromBundle ? "native_local_bundle" : "native";
   }
 
   return "depot";

apps/webapp/test/deploymentTelemetry.test.ts

@@ -2,8 +2,8 @@ import { describe, expect, it } from "vitest";
 import { deriveBuildPath, deriveDeploymentDurations } from "~/v3/deploymentTelemetry";
 
 describe("deriveBuildPath", () => {
-  it("classifies fromBundle native builds as local_bundle", () => {
-    expect(deriveBuildPath({ isNativeBuild: true, fromBundle: true })).toBe("local_bundle");
+  it("classifies fromBundle native builds as native_local_bundle", () => {
+    expect(deriveBuildPath({ isNativeBuild: true, fromBundle: true })).toBe("native_local_bundle");
   });
 
   it("classifies native builds without fromBundle as native", () => {
@@ -17,7 +17,7 @@ describe("deriveBuildPath", () => {
     expect(deriveBuildPath({})).toBe("depot");
     expect(deriveBuildPath({ buildId: "depot-build-id" })).toBe("depot");
     expect(deriveBuildPath({ isNativeBuild: false })).toBe("depot");
-    // fromBundle alone (skewed writer) must not count as local_bundle
+    // fromBundle alone (skewed writer) must not count as native_local_bundle
     expect(deriveBuildPath({ fromBundle: true })).toBe("depot");
     expect(deriveBuildPath("garbage")).toBe("depot");
   });