refactor: rename the terminal telemetry event to deployment.finished

Author: myftija

apps/webapp/app/v3/deploymentTelemetry.ts

@@ -1,8 +1,8 @@
 import { BuildServerMetadata } from "@trigger.dev/core/v3";
 
 /**
- * Attribute names for the `deployment.lifecycle` and `deployment.initialized`
- * telemetry events (emitted by services/recordDeploymentLifecycle.server.ts).
+ * Attribute names for the `deployment.finished` and `deployment.initialized`
+ * telemetry events (emitted by services/recordDeploymentFinished.server.ts).
  * This module is the single owner of these names — external queries,
  * dashboards, and monitors reference them, so treat renames as breaking.
  *
@@ -24,7 +24,7 @@ export const DeploymentTelemetryAttributes = {
   // Deployment friendly id — the dedup key
   DEPLOYMENT_ID: "deployment.id",
   VERSION: "deployment.version",
-  // lifecycle: terminal status; initialized: initial status (PENDING/BUILDING)
+  // finished: terminal status; initialized: initial status (PENDING/BUILDING)
   STATUS: "deployment.status",
   // status === DEPLOYED; CANCELED is excluded from failure rates
   SUCCESS: "deployment.success",

apps/webapp/app/v3/services/createDeploymentBackgroundWorkerV4.server.ts

@@ -18,7 +18,7 @@ import {
 } from "./createBackgroundWorker.server";
 import { findOrCreateBackgroundWorker } from "./createDeploymentBackgroundWorkerV4/findOrCreateBackgroundWorker.server";
 import { TimeoutDeploymentService } from "./timeoutDeployment.server";
-import { recordDeploymentLifecycle } from "./recordDeploymentLifecycle.server";
+import { recordDeploymentFinished } from "./recordDeploymentFinished.server";
 import { env } from "~/env.server";
 import { webhookPrisma } from "~/db.server";
 
@@ -335,7 +335,7 @@ export class CreateDeploymentBackgroundWorkerServiceV4 extends BaseService {
       // BUILDING → DEPLOYING transition.
       await TimeoutDeploymentService.dequeue(deployment.id, this._prisma);
 
-      recordDeploymentLifecycle({
+      recordDeploymentFinished({
         status: "FAILED",
         deployment: { ...deployment, status: "FAILED", failedAt, errorData },
         environment: {

apps/webapp/app/v3/services/deployment.server.ts

@@ -9,7 +9,7 @@ import {
   type DeploymentEvent,
 } from "@trigger.dev/core/v3";
 import { TimeoutDeploymentService } from "./timeoutDeployment.server";
-import { recordDeploymentLifecycle } from "./recordDeploymentLifecycle.server";
+import { recordDeploymentFinished } from "./recordDeploymentFinished.server";
 import { env } from "~/env.server";
 import { createRemoteImageBuild } from "../remoteImageBuilder.server";
 import { FINAL_DEPLOYMENT_STATUSES } from "./failDeployment.server";
@@ -252,9 +252,9 @@ export class DeploymentService extends BaseService {
       .andThen(validateDeployment)
       .andThen(cancelDeployment)
       .andThen(({ deployment }) =>
-        this.#recordCanceledLifecycle(deployment.id)
+        this.#recordCanceledTelemetry(deployment.id)
           .orElse((error) => {
-            logger.error("Failed to record canceled deployment lifecycle", { error });
+            logger.error("Failed to record canceled deployment telemetry", { error });
             return okAsync(undefined);
           })
           .map(() => ({ deployment }))
@@ -484,7 +484,7 @@ export class DeploymentService extends BaseService {
   }
 
   // The cancel chain only carries a narrow row selection, so re-fetch the full row
-  #recordCanceledLifecycle(deploymentId: string) {
+  #recordCanceledTelemetry(deploymentId: string) {
     return fromPromise(
       this._prisma.workerDeployment.findFirst({
         where: { id: deploymentId },
@@ -505,7 +505,7 @@ export class DeploymentService extends BaseService {
     ).map((canceled) => {
       if (!canceled || canceled.status !== "CANCELED") return;
 
-      recordDeploymentLifecycle({
+      recordDeploymentFinished({
         status: "CANCELED",
         deployment: canceled,
         environment: {

apps/webapp/app/v3/services/failDeployment.server.ts

@@ -5,7 +5,7 @@ import { boundedIn, Prisma, type WorkerDeploymentStatus } from "@trigger.dev/dat
 import { type FailDeploymentRequestBody } from "@trigger.dev/core/v3/schemas";
 import { type AuthenticatedEnvironment } from "~/services/apiAuth.server";
 import { DeploymentService } from "./deployment.server";
-import { recordDeploymentLifecycle } from "./recordDeploymentLifecycle.server";
+import { recordDeploymentFinished } from "./recordDeploymentFinished.server";
 
 export const FINAL_DEPLOYMENT_STATUSES: WorkerDeploymentStatus[] = [
   "CANCELED",
@@ -78,7 +78,7 @@ export class FailDeploymentService extends BaseService {
       return;
     }
 
-    recordDeploymentLifecycle({
+    recordDeploymentFinished({
       status: "FAILED",
       deployment: failedDeployment,
       environment: {

apps/webapp/app/v3/services/finalizeDeployment.server.ts

@@ -10,7 +10,7 @@ import { projectPubSub } from "./projectPubSub.server";
 import { FailDeploymentService } from "./failDeployment.server";
 import { TimeoutDeploymentService } from "./timeoutDeployment.server";
 import { DeploymentService } from "./deployment.server";
-import { recordDeploymentLifecycle } from "./recordDeploymentLifecycle.server";
+import { recordDeploymentFinished } from "./recordDeploymentFinished.server";
 import { engine } from "../runEngine.server";
 import { tryCatch } from "@trigger.dev/core";
 import { externalDeploymentCacheInstance } from "~/services/externalDeploymentCacheInstance.server";
@@ -101,7 +101,7 @@ export class FinalizeDeploymentService extends BaseService {
       buildEnvVars: null,
     };
 
-    recordDeploymentLifecycle({
+    recordDeploymentFinished({
       status: "DEPLOYED",
       deployment: finalizedDeployment,
       environment: {

apps/webapp/app/v3/services/initializeDeployment.server.ts

@@ -16,7 +16,7 @@ import { getDeploymentImageRef } from "../getDeploymentImageRef.server";
 import { tryCatch } from "@trigger.dev/core";
 import { getRegistryConfig } from "../registryConfig.server";
 import { DeploymentService } from "./deployment.server";
-import { recordDeploymentInitialized } from "./recordDeploymentLifecycle.server";
+import { recordDeploymentInitialized } from "./recordDeploymentFinished.server";
 import { createDeploymentWithNextVersion } from "./initializeDeployment/createDeploymentWithNextVersion.server";
 import {
   cancelSupersededDeployments,

…ices/recordDeploymentLifecycle.server.ts …vices/recordDeploymentFinished.server.tsapps/webapp/app/v3/services/recordDeploymentLifecycle.server.ts renamed to apps/webapp/app/v3/services/recordDeploymentFinished.server.ts apps/webapp/app/v3/services/recordDeploymentLifecycle.server.ts renamed to apps/webapp/app/v3/services/recordDeploymentFinished.server.ts

@@ -13,7 +13,7 @@ type TerminalDeploymentStatus = Extract<
   "DEPLOYED" | "FAILED" | "TIMED_OUT" | "CANCELED"
 >;
 
-type LifecycleDeployment = Pick<
+type FinishedDeployment = Pick<
   WorkerDeployment,
   | "friendlyId"
   | "version"
@@ -46,15 +46,15 @@ type EnvironmentInfo = {
 
 /**
  * Records a deployment's terminal transition as a single wide
- * `deployment.lifecycle` span, backdated createdAt → terminal (attribute
+ * `deployment.finished` span, backdated createdAt → terminal (attribute
  * contract in ../deploymentTelemetry.ts). Call exactly once, only after a
  * guarded status write confirmed this caller won the transition. Emitted on
  * ROOT_CONTEXT with forceRecording so the sampler can never drop it; never
  * throws.
  */
-export function recordDeploymentLifecycle(params: {
+export function recordDeploymentFinished(params: {
   status: TerminalDeploymentStatus;
-  deployment: LifecycleDeployment;
+  deployment: FinishedDeployment;
   environment: EnvironmentInfo;
   reason?: string;
 }): void {
@@ -68,7 +68,7 @@ export function recordDeploymentLifecycle(params: {
     const errorData = parseErrorData(deployment.errorData);
 
     const span = tracer.startSpan(
-      "deployment.lifecycle",
+      "deployment.finished",
       {
         startTime: deployment.createdAt,
         attributes: {
@@ -112,7 +112,7 @@ export function recordDeploymentLifecycle(params: {
 
     span.end(terminalAt);
   } catch (error) {
-    logger.debug("recordDeploymentLifecycle failed", {
+    logger.debug("recordDeploymentFinished failed", {
       deploymentFriendlyId: params.deployment.friendlyId,
       error: error instanceof Error ? error.message : String(error),
     });
@@ -121,7 +121,7 @@ export function recordDeploymentLifecycle(params: {
 
 /**
  * Records a deployment's creation as a zero-duration `deployment.initialized`
- * event — the funnel counterpart to `deployment.lifecycle` for detecting
+ * event — the funnel counterpart to `deployment.finished` for detecting
  * stuck deployments. Never throws.
  */
 export function recordDeploymentInitialized(params: {

apps/webapp/app/v3/services/timeoutDeployment.server.ts

@@ -5,7 +5,7 @@ import { commonWorker } from "../commonWorker.server";
 import { PerformDeploymentAlertsService } from "./alerts/performDeploymentAlerts.server";
 import { type PrismaClientOrTransaction } from "~/db.server";
 import { DeploymentService } from "./deployment.server";
-import { recordDeploymentLifecycle } from "./recordDeploymentLifecycle.server";
+import { recordDeploymentFinished } from "./recordDeploymentFinished.server";
 
 export class TimeoutDeploymentService extends BaseService {
   public async call(id: string, fromStatus: string, errorMessage: string) {
@@ -71,7 +71,7 @@ export class TimeoutDeploymentService extends BaseService {
       buildEnvVars: null,
     };
 
-    recordDeploymentLifecycle({
+    recordDeploymentFinished({
       status: "TIMED_OUT",
       deployment: timedOutDeployment,
       environment: {