Add assembly linting support #294
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b3089f5a7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| for (const [stepName, step] of Object.entries(stepsRecord)) { | ||
| if (stepName !== ':original' && isObject(step) && !('use' in step) && 'robot' in step) { | ||
| // Use addUseReference instead of direct assignment | ||
| // @ts-expect-error: robot should be good here | ||
| addUseReference({ ...step, use: [] }, ':original') |
There was a problem hiding this comment.
In fixMissingInput, addUseReference returns a new StepInput rather than mutating the original step. Because its return value is ignored here, steps without use never get updated when --fix is used, so the “missing input” auto-fix does not actually wire steps to :original and the resulting instructions can still be missing required use references. Assign the returned value back into stepsRecord[stepName] to apply the fix.
Useful? React with 👍 / 👎.
Summary
Testing