Downgrade Docker 16.04 to upgrade llvm#394
Open
acpaquette wants to merge 3 commits intotrailofbits:masterfrom
Open
Downgrade Docker 16.04 to upgrade llvm#394acpaquette wants to merge 3 commits intotrailofbits:masterfrom
acpaquette wants to merge 3 commits intotrailofbits:masterfrom
Conversation
Author
|
Another potential solution would be to pin the llvm install to llvm 10, then pull the correct version of Angora to build against that. That would allow the container to remain at Ubuntu 18.04 and remove the anaconda environment from the build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the dockerfile to build with an updated llvm package. Unfortunately this requires that the ubuntu container be downgraded to 16.04 because llvm stopped supporting 18.04 seemingly.
There is also the addition of a conda env into the image which isn't ideal but this was the easiest way to update the python version on 16.04