Open
Conversation
d7698c4 to
ee5f1a6
Compare
fdd743c to
6356d8e
Compare
6356d8e to
397ea2f
Compare
397ea2f to
be18179
Compare
Contributor
|
Hi @adrianherrera , We recently switched to Python3. Can you update your PR? Do you need some help with that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hellooooo DeepState devs (hey @pgoodman!),
Here is my PR for adding S2E support to DeepState. Note that it requires some upstream changes to S2E that I haven't yet merged (or even made a PR for. I'll get there), so the Python scripts won't work "out-of-the-box" yet. I've only done minimal testing of the supplied
examples/: If you have something more meaty for me to test, please let me know.For now I'm mainly after feedback on code style, how I've written the S2E "executor" (it's very different to Manticore/Angr, due to the differences in how you use S2E), documentation, etc. Please don't merge until I've updated upstream S2E 🙂
Cheers,
Adrian