Fix for using FLAG_IMMUTABLE when creating PendingIntent targeting S+ (version 31 and above)#10
Open
uyaribrahim wants to merge 1 commit into
Open
Conversation
…IMMUTABLE for PendingIntent creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue that arises when creating a PendingIntent targeting S+ (version 31 and above) without specifying either FLAG_IMMUTABLE or FLAG_MUTABLE. The change implements a resolution by utilizing PendingIntent.FLAG_IMMUTABLE for creating the PendingIntent, as recommended.
This modification enhances security and performance by employing the recommended FLAG_IMMUTABLE, providing a PendingIntent that is immutable and therefore safer for use. FLAG_MUTABLE is only necessary in specific cases, such as inline replies or bubbles.
This pull request aims to ensure compatibility with S+ version and above by embracing and applying the usage of FLAG_IMMUTABLE.
Changes:
Implemented PendingIntent creation using PendingIntent.FLAG_IMMUTABLE