Skip to content

Conversation

@bradhe
Copy link
Contributor

@bradhe bradhe commented May 1, 2025

We've got some drift across the different commands in terms of how parameters are extracted, how users supply parameters to commands, etc. This PR standardizes most (all?) of the existing interactions.

@bradhe bradhe requested review from Copilot and sankroh May 1, 2025 11:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes interactions with Tower commands by unifying parameter extraction and renaming functions for apps, secrets, and teams. Key changes include introducing a new utility module for flag extraction, renaming command handler functions for consistency, and updating error messages and help texts across the commands.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/tower-cmd/src/util/mod.rs New module "cmd" added to support flag extraction across commands
crates/tower-cmd/src/util/cmd.rs Added helper functions get_string_flag and get_bool_flag for standardization
crates/tower-cmd/src/teams.rs Renamed functions and extracted team slug parsing logic
crates/tower-cmd/src/secrets.rs Updated flag extraction and function names to match new conventions
crates/tower-cmd/src/lib.rs Updated command dispatch to use the new standardized command handler names
crates/tower-cmd/src/apps.rs Renamed and updated functions and help messages for improved consistency
Comments suppressed due to low confidence (1)

crates/tower-cmd/src/apps.rs:16

  • There is a stray backtick in the help text of the list subcommand. Removing the backtick will improve clarity.
.subcommand(Command::new("list").about("List all of your apps`")

@bradhe bradhe merged commit 0ac9ba2 into develop May 4, 2025
4 checks passed
@bradhe bradhe deleted the feature/tow-358-cli-tower-apps-show-hello-world-does-not-work-anymore branch May 4, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants