Abort execution when installation fails #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradhe
requested review from
Copilot,
jo-sm,
konstantinoscs,
sammuti and
socksy
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that application execution aborts immediately when dependency installation fails during startup, rather than continuing with broken dependencies. The implementation adds proper error handling for uv venv and uv sync failures, returning Crashed status with appropriate error variants.
Changes:
- Added error handling to abort execution when
uv venvoruv syncprocesses exit with non-zero codes - Created a test example app with intentionally broken dependencies to verify failure behavior
- Added test case to verify apps crash with non-zero exit code when dependency installation fails
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/tower-runtime/src/local.rs | Added exit code checks for venv creation and dependency sync processes, returning errors when they fail |
| crates/tower-runtime/src/errors.rs | Added DependencyInstallationFailed error variant |
| crates/tower-runtime/tests/local_test.rs | Added test to verify crash behavior on dependency installation failure |
| crates/tower-runtime/tests/example-apps/05-broken-dependencies/pyproject.toml | Created test app with non-existent dependency |
| crates/tower-runtime/tests/example-apps/05-broken-dependencies/main.py | Added placeholder script that should never execute |
| crates/tower-runtime/tests/example-apps/05-broken-dependencies/Towerfile | Created Towerfile configuration for broken dependencies test app |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
konstantinoscs
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all. When uv venv or uv sync fails during app startup, execution now aborts immediately with a
Crashedstatus (because the developer needs to fix the issue) instead of continuing. Added 05-broken-dependencies example app with an intentionally non-existent package and addedtest_abort_on_dependency_installation_failuretest that verifies the app crashes with a non-zero exit code when dependency installation fails.This was probably historically missed because the apps would fail anyway along the way.