feat: enable non-'static where possible#732
Closed
Daniel-Bloom-dfinity wants to merge 2 commits into
Closed
Conversation
GlenDC
reviewed
Dec 4, 2023
GlenDC
left a comment
GlenDC
left a comment
Contributor
There was a problem hiding this comment.
Looks like a welcome change, but it is breaking, no? So probably has to wait for a next minor version updatae?
Member
|
Closing in favor in #765. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, many tower service wrappers and layers are limited to working with
'statictypes, which limits its usefulness when working with non-statically borrowed things to and from scoped tasks (e.g.async-scoped).Solution
Remove the
'staticrestrictions where possible, mostly by introducing lifetime parameters.This change excludes
BufferandBufferLayerwhich are more difficult to make non-'static. It is possible to do by abstractingtokio::spawninto a trait (whichasync_scoped::Scopecan also implement), this is also pending the publish of the recently merged tokio-rs/tokio#5665.