Skip to content

PM-4825 task payment approver#1764

Merged
vas3a merged 3 commits intodevfrom
PM-4825_task-payment-approver
Apr 24, 2026
Merged

PM-4825 task payment approver#1764
vas3a merged 3 commits intodevfrom
PM-4825_task-payment-approver

Conversation

@vas3a
Copy link
Copy Markdown
Collaborator

@vas3a vas3a commented Apr 24, 2026

Related JIRA Ticket:

https://topcoder.atlassian.net/browse/PM-4825

What's in this PR?

This pull request updates the payments admin UI and logic to generalize the "Engagement Payment Approver" role to a broader "Payment Approver" role, and expands the default filters and allowed categories for approvers. It also improves how filters are applied and displayed for different roles, ensuring that payment approvers can view and filter both task and engagement payments, and that the UI and tests reflect these changes.

Role and terminology updates:

  • All references to the "Engagement Payment Approver" role and view have been replaced with the more general "Payment Approver" role and view, including variable names, button labels, and test descriptions.

Default filters and allowed categories:

  • For payment approvers, the default filters now include both the "TASK_PAYMENT" and "ENGAGEMENT_PAYMENT" categories, and the default status is "ON_HOLD_ADMIN". The logic for applying and displaying filters has been updated to support this.

UI improvements:

  • The category dropdown for payment approvers now allows selecting between "All", "Task Payments", and "Engagement Payments", reflecting the expanded scope of the role.
  • The role view toggle button is now labeled "Approver View" instead of "Engagement Approver View".

API filter handling:

  • The filter logic in fetchWinnings has been updated to support passing arrays for the categories filter, ensuring that the backend receives the correct filter format.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

@vas3a vas3a merged commit 042a252 into dev Apr 24, 2026
9 checks passed
@vas3a vas3a deleted the PM-4825_task-payment-approver branch April 24, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant