Conversation
PM-3532 Revert api response structure
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (_.includes(traitIds, 'personalization') && | ||
| !_.isEmpty(traitData.personalization) | ||
| ) { | ||
| const collectInfo = {} |
There was a problem hiding this comment.
[💡 readability]
The collectInfo object is initialized outside the loop but is only used within the loop. Consider moving its declaration inside the loop to limit its scope and improve readability.
| data: _.map(traitData.personalization, t => ({ | ||
| [t.key]: t.value | ||
| })) | ||
| data: [collectInfo] |
There was a problem hiding this comment.
[❗❗ correctness]
The change from using _.map to constructing a single collectInfo object and wrapping it in an array could lead to different behavior if traitData.personalization contains multiple entries with the same key. The previous implementation would have created an array of objects, while the new implementation overwrites values for duplicate keys. Ensure this change is intentional and aligns with the desired functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-3688