Conversation
feat(PM-3317): Profile download API endpoint initial implementation
fix(PM-3317): included talent manager to check for profile downloadable role
feat(PM-3398): adding description and skills to member work trait
PM-3397 Add member email in response for PM and TM
fix(PM-3318): QA feedbacks on PDF implementation
PM 3532 OPen to work feature
…bulk-search results.
PM-3532 Return all rows for privilged user
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| only: | ||
| - develop | ||
| - PM-3532 | ||
| - pm-2539 |
There was a problem hiding this comment.
[💡 maintainability]
Branch names should follow a consistent naming convention for clarity and maintainability. Consider using a consistent case format, such as all lowercase or camelCase, for branch names.
| fields: Joi.string() | ||
| }), | ||
| data: Joi.object().keys({ | ||
| handle: Joi.forbidden(), |
There was a problem hiding this comment.
[maintainability]
The handle and handleLower fields are listed twice in the Joi schema definition. This redundancy should be removed to avoid confusion and potential errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.