Conversation
What was broken The My Assignments endpoint only returned engagements where the authenticated member had a selected or assigned record, so completed and terminated engagement details disappeared from the member view. Root cause findMyAssignments reused the active assignment status list for both the engagement filter and included assignment records. What was changed Added a My Assignments status set that includes SELECTED, ASSIGNED, COMPLETED, and TERMINATED. The endpoint now uses that set for member assignment filtering, and the API documentation describes active and past assignments. Any added/updated tests Added an EngagementsService test covering active and past assignment records in the My Assignments query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The My Assignments endpoint only returned engagements where the authenticated member had a selected or assigned record, so completed and terminated engagement details disappeared from the member view.
Root cause
findMyAssignments reused the active assignment status list for both the engagement filter and included assignment records.
What was changed
Added a My Assignments status set that includes SELECTED, ASSIGNED, COMPLETED, and TERMINATED. The endpoint now uses that set for member assignment filtering, and the API documentation describes active and past assignments.
Any added/updated tests
Added an EngagementsService test covering active and past assignment records in the My Assignments query.