fix: improve numeric literal validation#21
Open
smortezah wants to merge 3 commits intotoon-format:mainfrom
Open
fix: improve numeric literal validation#21smortezah wants to merge 3 commits intotoon-format:mainfrom
smortezah wants to merge 3 commits intotoon-format:mainfrom
Conversation
Contributor
|
@bpradana pls do. Thanks a lot |
davidpirogov
previously approved these changes
Nov 9, 2025
davidpirogov
approved these changes
Nov 9, 2025
Contributor
davidpirogov
left a comment
There was a problem hiding this comment.
Minor update to test asserts, otherwise looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves numeric literal detection and ensures consistency between encoder and decoder utilities. It refines the
is_numeric_literalfunction to properly handle negative numbers with leading zeros, and introduces a comprehensive test suite to verify numeric detection logic and round-trip encoding/decoding behavior.Numeric literal detection improvements
is_numeric_literalinsrc/toon_format/_literal_utils.pyto correctly reject negative numbers with leading zeros (e.g.,-01), ensuring stricter validation of numeric literals.Test coverage enhancements
tests/test_numeric_detection.pywith extensive tests for bothis_numeric_literalandis_numeric_like, covering valid numbers, floats, scientific notation, leading zeros, non-numeric strings, and special float values.