Repository navigation
fix(optimizer): do not hoist subqueries across anonymous function boundaries - #8884
Merged
Merged
Conversation
Contributor
SQLGlot Integration Test Results✅ All tests passedComparing: Overallmain: 182929 total, 166022 passed (pass rate: 90.8%) sqlglot:trey/no-hoist-anon: 182929 total, 166022 passed (pass rate: 90.8%) Transitions: ✅ All tests passed |
georgesittas
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLGlot can move a child subquery into a join before establishing whether the surrounding anonymous function is scalar or aggregate.
For aggregates SQLGlot does not recognize, this can produce invalid SQL: either a joined column outside aggregation or a
MAX(...)nested inside another aggregate.With this PR, sqlglot will not move a child through an anonymous function, even when the parent has explicit grouping.