Skip to content

test(voice): align ElevenLabs test fixtures stt_api_style to elevenlabs - #5949

Open
AdityaThakur193 wants to merge 1 commit into
tinyhumansai:mainfrom
AdityaThakur193:test/voice-elevenlabs-fixture-accuracy
Open

test(voice): align ElevenLabs test fixtures stt_api_style to elevenlabs#5949
AdityaThakur193 wants to merge 1 commit into
tinyhumansai:mainfrom
AdityaThakur193:test/voice-elevenlabs-fixture-accuracy

Conversation

@AdityaThakur193

@AdityaThakur193 AdityaThakur193 commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • Aligns all 5 ElevenLabs test fixtures in VoicePanel.test.tsx (lines 92, 471, 584, 835, 867) to stt_api_style: 'elevenlabs'.
  • Resolves test-fixture drift with the core Rust schema (config/schema/voice_providers.rs -> SttApiStyle::ElevenLabs).
  • Pure test-fixture accuracy cleanup across the entire test file.

Problem

  • The ElevenLabs test provider fixtures in VoicePanel.test.tsx contained stale stt_api_style: 'openai_audio' fields from initial copy-paste templates, out of alignment with the Rust core SttApiStyle::ElevenLabs schema.

Solution

  • Updated all 5 occurrences of stt_api_style in ElevenLabs fixtures within VoicePanel.test.tsx to 'elevenlabs'.
  • Verified that all 39 unit tests in VoicePanel.test.tsx pass.

Submission Checklist

  • Tests added or updated (happy path + at least one failure / edge case) per Testing Strategy
  • Diff coverage ≥ 80% — changed lines meet the gate enforced by .github/workflows/ci-lite.yml.
  • Coverage matrix updated — N/A: test fixture alignment only
  • All affected feature IDs from the matrix are listed in the PR description under ## Related
  • No new external network dependencies introduced
  • Manual smoke checklist updated — N/A: test fixture change only
  • Linked issue closed via Closes #NNN in the ## Related section

Impact

  • Improves test fixture schema accuracy for ElevenLabs voice settings.
  • Zero runtime or production code changes.

Related

  • Closes: N/A
  • Follow-up PR(s)/TODOs: N/A

AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: test/voice-elevenlabs-fixture-accuracy
  • Commit SHA: 974f377

Validation Run

  • pnpm --filter openhuman-app format:check
  • pnpm typecheck
  • Focused tests: pnpm --filter openhuman-app test --run src/components/settings/panels/__tests__/VoicePanel.test.tsx (39/39 passed)
  • Rust fmt/check (if changed): N/A
  • Tauri fmt/check (if changed): N/A

Validation Blocked

  • command: N/A
  • error: N/A
  • impact: N/A

Behavior Changes

  • Intended behavior change: Aligns all 5 ElevenLabs test provider fixtures with stt_api_style: 'elevenlabs'.
  • User-visible effect: None (Test fixture schema accuracy cleanup).

Parity Contract

  • Legacy behavior preserved: Yes.
  • Guard/fallback/dispatch parity checks: Yes.

Duplicate / Superseded PR Handling

Summary by CodeRabbit

  • Tests
    • Updated ElevenLabs provider test fixtures to use the correct speech-to-text API style.
    • No user-facing behavior or application functionality changed.

@AdityaThakur193
AdityaThakur193 requested review from a team and a lite review from Copilot September 2, 2026 05:50
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: ad113ada-9222-41ae-a7ce-137424afdcbc

📥 Commits

Reviewing files that changed from the base of the PR and between 61d25fe and 974f377.

📒 Files selected for processing (1)
  • app/src/components/settings/panels/__tests__/VoicePanel.test.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The change updates five ElevenLabs provider fixtures in VoicePanel.test.tsx. Each fixture now uses elevenlabs for stt_api_style. Test logic and assertions remain unchanged.

Changes

Voice panel test fixtures

Layer / File(s) Summary
Align ElevenLabs fixture API styles
app/src/components/settings/panels/__tests__/VoicePanel.test.tsx
The shared and inline ElevenLabs provider fixtures now set stt_api_style to elevenlabs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 974f3

This change only corrects ElevenLabs test fixtures and does not affect runtime or production behavior; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: m3ga-mind

Poem

A rabbit checks the voices bright
Five fixtures now point right
ElevenLabs hops in tune
Tests keep their steady moon
No assertions leap away

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating ElevenLabs voice test fixtures to use the correct stt_api_style value.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch, ai_padded_prose). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0024 · 26,197 in / 298 out · 0 cached (0%) · openrouter/openai/text-embedding-3-small, deepseek/deepseek-v4-flash · 59 embedded
critique:    $0.0010 · 11,004 in / 111 out · 0 cached (0%) · deepseek/deepseek-v4-flash
security:    $0.0010 · 10,983 in / 87 out  · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0004 · 4,210 in  / 100 out · 0 cached (0%) · deepseek/deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are limited to test-fixture constants and align them with the established Rust schema without affecting runtime behavior.

Pull request overview

This PR updates the frontend unit-test fixtures for the ElevenLabs voice provider so their stt_api_style matches the Rust core schema (SttApiStyle::ElevenLabs → serialized as elevenlabs). This keeps the VoicePanel test suite aligned with the real provider contract and avoids fixture-driven false negatives.

Changes:

  • Updated ELEVENLABS_PROVIDER fixture to use stt_api_style: 'elevenlabs'.
  • Updated four additional inline ElevenLabs provider fixtures in VoicePanel.test.tsx to use stt_api_style: 'elevenlabs'.
File summaries
File Description
app/src/components/settings/panels/tests/VoicePanel.test.tsx Aligns all ElevenLabs test fixtures’ stt_api_style to elevenlabs to match core schema and prevent fixture drift.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants