test(voice): align ElevenLabs test fixtures stt_api_style to elevenlabs - #5949
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change updates five ElevenLabs provider fixtures in ChangesVoice panel test fixtures
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only corrects ElevenLabs test fixtures and does not affect runtime or production behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Comment Warning |
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0024 · 26,197 in / 298 out · 0 cached (0%) · openrouter/openai/text-embedding-3-small, deepseek/deepseek-v4-flash · 59 embedded
critique: $0.0010 · 11,004 in / 111 out · 0 cached (0%) · deepseek/deepseek-v4-flash
security: $0.0010 · 10,983 in / 87 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0004 · 4,210 in / 100 out · 0 cached (0%) · deepseek/deepseek-v4-flash
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to test-fixture constants and align them with the established Rust schema without affecting runtime behavior.
Pull request overview
This PR updates the frontend unit-test fixtures for the ElevenLabs voice provider so their stt_api_style matches the Rust core schema (SttApiStyle::ElevenLabs → serialized as elevenlabs). This keeps the VoicePanel test suite aligned with the real provider contract and avoids fixture-driven false negatives.
Changes:
- Updated
ELEVENLABS_PROVIDERfixture to usestt_api_style: 'elevenlabs'. - Updated four additional inline ElevenLabs provider fixtures in
VoicePanel.test.tsxto usestt_api_style: 'elevenlabs'.
File summaries
| File | Description |
|---|---|
| app/src/components/settings/panels/tests/VoicePanel.test.tsx | Aligns all ElevenLabs test fixtures’ stt_api_style to elevenlabs to match core schema and prevent fixture drift. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Summary
VoicePanel.test.tsx(lines 92, 471, 584, 835, 867) tostt_api_style: 'elevenlabs'.config/schema/voice_providers.rs->SttApiStyle::ElevenLabs).Problem
VoicePanel.test.tsxcontained stalestt_api_style: 'openai_audio'fields from initial copy-paste templates, out of alignment with the Rust coreSttApiStyle::ElevenLabsschema.Solution
stt_api_stylein ElevenLabs fixtures withinVoicePanel.test.tsxto'elevenlabs'.VoicePanel.test.tsxpass.Submission Checklist
.github/workflows/ci-lite.yml.## RelatedCloses #NNNin the## RelatedsectionImpact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
test/voice-elevenlabs-fixture-accuracy974f377Validation Run
pnpm --filter openhuman-app format:checkpnpm typecheckpnpm --filter openhuman-app test --run src/components/settings/panels/__tests__/VoicePanel.test.tsx(39/39 passed)Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
stt_api_style: 'elevenlabs'.Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit