feat(hosting): add hosting_deployment_logs - #5833
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueWarning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Comment |
75065f5 to
056379c
Compare
|
Maintainer housekeeping — I rebased this branch onto current What conflicted, and how I resolved it1. Resolution: kept
2. Verified locally after the rebase
Same numbers you reported, so the relocation into the fragment is faithful. One thing to fix before this can merge — the pin is a downgrade, not just temporaryYour note says to re-pin at the tinyhosts
No API is lost (I checked — that is why it still compiles), but two dependency bumps get reverted repo-wide. Merging current Also: Leaving this as a draft — it is correctly blocked on tinyhosts#4, which is still open. Not approving; a maintainer reviews and merges. |
|
CI came back after the rebase. Two new red checks, both the same root cause — the 1. There is an escape hatch, but I would not reach for it — merging current tinyhosts 2. Same cause. The rebase brought Worth flagging why neither of us caught this locally: the verification lanes in your PR description, and the ones I ran after the rebase, do not pass Net effect of the rebase: Once tinyhosts#4 merges current |
TEMPORARY. `hosting_deployment_logs` needs `Host::deployment_logs`, which lives on tinyhumansai/tinyhosts#4 and is not on that repo's `main` yet. The pin here is that PR's head so this branch compiles and can be reviewed. Re-pin to the merge commit on tinyhosts `main` before this merges. Until then this branch must not land.
`hosting_deployment_status` reports *that* a build failed and carries the provider's one-line error. Nothing returned the build output, so an agent that broke a deploy could report the failure but not diagnose it — it had to roll back blind or hand the problem to a human. Adds the tenth `hosting_*` tool over `Host::deployment_logs`. Read-only, no external effect, same deployment id as `hosting_deployment_status`. The log is trimmed to the most recent `limit` events (default 100) because a build can record thousands of lines. The trim keeps the tail deliberately: the failure that sent an agent here is at the end, so dropping the head loses setup noise rather than the error. Closes part of tinyhumansai/opencompany#913.
056379c to
3e42bdc
Compare
|
Maintainer pass — I rebased this branch onto current WhyThe branch was 44 commits behind How, and what I did not doDone with Your two commits are intact and still yours:
Author on both is still One side effect worth knowing: GitHub's server-side rebase drops commit signatures. Both commits were signed before and are unsigned now. CI: same three failures as before the rebase — I introduced nonePre-rebase run They are not all yours, though, so it's worth separating them. Yours — one root cause, two symptoms
Both clear the moment the pin moves forward to something at or after Not yours, and not mine —
|
Adds
hosting_deployment_logs, the tenthhosting_*tool and the last one outstanding for tinyhumansai/opencompany#913.Why
hosting_deployment_statusreports that a build failed and carries the provider's one-line error. Nothing returned the build output, so an agent that shipped a broken deploy could report the failure but not diagnose it — roll back blind, or hand it to a human. This is the read that makes a failed deploy actionable.What
DeploymentLogsTooloverHost::deployment_logs, registered next to the other deployment reads.deployment_idashosting_deployment_status.limit(default 100, clamped 1–1000). A build can record thousands of lines, which is a context window rather than a bill. The trim keeps the tail — the failure that sent an agent here is at the end, so dropping the head loses setup noise rather than the error.README.mdand the two module docs updated nine → ten.Do not merge yet — the pin is temporary
Host::deployment_logsis on tinyhumansai/tinyhosts#4, which has not merged. The first commit here pinsvendor/tinyhostsat that PR's head (c0ff407) purely so this branch compiles and can be reviewed.Before this merges: re-pin
vendor/tinyhoststo the merge commit on tinyhostsmain. I'll push that as soon as #4 lands.For anyone looking at #4's red
Rustcheck: it fails on a lint inherited from tinyhostsmainthat tinyhosts#7 already fixed there. Its last CI run predates that fix, and a re-run replays the same stale merge ref — it needs a close+reopen or a rebase, not a code change. Full detail on that PR.Verification
Run locally against the pinned tinyhosts:
cargo fmt -- --checkcargo clippy -p openhuman --features "$(bash scripts/ci/product-features.sh)" -- -D warningscargo clippy -p openhuman -- -D warnings(contributor set)cargo build --features hostingcargo test --features hosting hosting::hostingis inscripts/ci/product-features.txt, so the product clippy lane does cover this code.After this
opencompany bumps its
vendor/openhumanpin, declares the tool and gives it a consequence row — itshosting_prefix defeatsREAD_ONLY_PREFIXES, so an undeclared hosting read parks rather than running. That's the last step before opencompany#913 closes.