Repository navigation
docs: document L2CAP support and add a build workflow - #18
Merged
Merged
Conversation
Member
|
Great work here @acouvreur thank you very much! Now merging the stack... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #17, which clears the failures this workflow reports, so it passes from its first run instead of arriving red.
L2CAP support went in without a mention in the README, so the only way to learn that channels exist, and that reads and writes on them do not block, is to read the source.
The repository also has no CI at all. Nothing compiles a proposed change before it is merged, on a codebase where most of the surface is Objective C reached through cgo and can only be built on macOS. A mistake there is invisible to review and only surfaces once someone pulls the change into their own project.
A macOS build and vet job puts a compiler in front of changes before they land, and a short README section makes the feature discoverable.
Replaces #15, which was opened against the wrong base.