Skip to content

ci: fix Agnocast CI#437

Draft
mojomex wants to merge 6 commits intomainfrom
ci/fix-agnocast-env-var-name
Draft

ci: fix Agnocast CI#437
mojomex wants to merge 6 commits intomainfrom
ci/fix-agnocast-env-var-name

Conversation

@mojomex
Copy link
Copy Markdown
Collaborator

@mojomex mojomex commented Apr 16, 2026

PR Type

  • Improvement

Related Links

Description

This PR is a new incarnation of #422, fixing the Agnocast env var name in CI. Previously it was wrong and completely ignored by colcon/Nebula, resulting in a non-Agnocast build being labeled with Agnocast.

CI now tests compilation with/without Agnocast for Hubmle/Jazzy. Since Agnocast kmod is not available in CI, Agnocast is disabled during the test step, resulting in the Agnocast lib falling back to ROS2 comms internally.

ROS distro sync finished for both Hubmle and Jazzy, so agnocastlib and agnocast_components are both available, making CI pass now.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

mojomex added 6 commits April 16, 2026 17:31
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
… workflow

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.20%. Comparing base (9cb61cc) to head (466fc1e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   40.20%   40.20%           
=======================================
  Files         131      131           
  Lines       10280    10280           
  Branches     5393     5393           
=======================================
  Hits         4133     4133           
  Misses       3796     3796           
  Partials     2351     2351           
Flag Coverage Δ
nebula_continental 28.82% <ø> (?)
nebula_hesai 28.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant