-
Notifications
You must be signed in to change notification settings - Fork 3
add binlog fiter #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add binlog fiter #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has checked 861 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 0 | 221 | 640 | 0 |
Click to see the invalid file list
- cmd/manifest/update_latest_version.go
- cmd/ticloud/main.go
- gen_doc.go
- install.sh
- internal/cli/auth/auth.go
- internal/cli/auth/login.go
- internal/cli/auth/logout.go
- internal/cli/auth/whoami.go
- internal/cli/config/config.go
- internal/cli/config/create.go
- internal/cli/config/create_test.go
- internal/cli/config/delete.go
- internal/cli/config/delete_test.go
- internal/cli/config/describe.go
- internal/cli/config/describe_test.go
- internal/cli/config/edit.go
- internal/cli/config/list.go
- internal/cli/config/list_test.go
- internal/cli/config/set.go
- internal/cli/config/set_test.go
- internal/cli/config/use.go
- internal/cli/config/use_test.go
- internal/cli/project/list.go
- internal/cli/project/list_test.go
- internal/cli/project/project.go
- internal/cli/root.go
- internal/cli/root_test.go
- internal/cli/serverless/auditlog/auditlog.go
- internal/cli/serverless/auditlog/config/config.go
- internal/cli/serverless/auditlog/config/describe.go
- internal/cli/serverless/auditlog/config/ui.go
- internal/cli/serverless/auditlog/config/update.go
- internal/cli/serverless/auditlog/download.go
- internal/cli/serverless/auditlog/download_with_prompt.go
- internal/cli/serverless/auditlog/download_without_prompt.go
- internal/cli/serverless/auditlog/filter/create.go
- internal/cli/serverless/auditlog/filter/delete.go
- internal/cli/serverless/auditlog/filter/describe.go
- internal/cli/serverless/auditlog/filter/filter.go
- internal/cli/serverless/auditlog/filter/list.go
- internal/cli/serverless/auditlog/filter/template.go
- internal/cli/serverless/auditlog/filter/update.go
- internal/cli/serverless/authorizednetwork/authorized_network.go
- internal/cli/serverless/authorizednetwork/create.go
- internal/cli/serverless/authorizednetwork/create_test.go
- internal/cli/serverless/authorizednetwork/delete.go
- internal/cli/serverless/authorizednetwork/delete_test.go
- internal/cli/serverless/authorizednetwork/list.go
- internal/cli/serverless/authorizednetwork/list_test.go
- internal/cli/serverless/authorizednetwork/update.go
- internal/cli/serverless/authorizednetwork/update_test.go
- internal/cli/serverless/backup/backup.go
- internal/cli/serverless/backup/delete.go
- internal/cli/serverless/backup/delete_test.go
- internal/cli/serverless/backup/describe.go
- internal/cli/serverless/backup/describe_test.go
- internal/cli/serverless/backup/list.go
- internal/cli/serverless/backup/list_test.go
- internal/cli/serverless/branch/branch.go
- internal/cli/serverless/branch/create.go
- internal/cli/serverless/branch/create_test.go
- internal/cli/serverless/branch/delete.go
- internal/cli/serverless/branch/delete_test.go
- internal/cli/serverless/branch/describe.go
- internal/cli/serverless/branch/describe_test.go
- internal/cli/serverless/branch/list.go
- internal/cli/serverless/branch/list_test.go
- internal/cli/serverless/branch/reset.go
- internal/cli/serverless/branch/reset_test.go
- internal/cli/serverless/branch/shell.go
- internal/cli/serverless/capacity.go
- internal/cli/serverless/capacity_test.go
- internal/cli/serverless/changefeed/changefeed.go
- internal/cli/serverless/changefeed/create.go
- internal/cli/serverless/changefeed/delete.go
- internal/cli/serverless/changefeed/describe.go
- internal/cli/serverless/changefeed/edit.go
- internal/cli/serverless/changefeed/list.go
- internal/cli/serverless/changefeed/pause.go
- internal/cli/serverless/changefeed/resume.go
- internal/cli/serverless/changefeed/template.go
- internal/cli/serverless/changefeed/ui.go
- internal/cli/serverless/cluster.go
- internal/cli/serverless/create.go
- internal/cli/serverless/create_test.go
- internal/cli/serverless/dataimport/cancel.go
- internal/cli/serverless/dataimport/cancel_test.go
- internal/cli/serverless/dataimport/describe.go
- internal/cli/serverless/dataimport/describe_test.go
- internal/cli/serverless/dataimport/import.go
- internal/cli/serverless/dataimport/list.go
- internal/cli/serverless/dataimport/list_test.go
- internal/cli/serverless/dataimport/start/azblob.go
- internal/cli/serverless/dataimport/start/azblob_test.go
- internal/cli/serverless/dataimport/start/gcs.go
- internal/cli/serverless/dataimport/start/gcs_test.go
- internal/cli/serverless/dataimport/start/local.go
- internal/cli/serverless/dataimport/start/local_test.go
- internal/cli/serverless/dataimport/start/oss.go
- internal/cli/serverless/dataimport/start/oss_test.go
- internal/cli/serverless/dataimport/start/s3.go
- internal/cli/serverless/dataimport/start/s3_test.go
- internal/cli/serverless/dataimport/start/start.go
- internal/cli/serverless/delete.go
- internal/cli/serverless/delete_test.go
- internal/cli/serverless/describe.go
- internal/cli/serverless/describe_test.go
- internal/cli/serverless/export/cancel.go
- internal/cli/serverless/export/cancel_test.go
- internal/cli/serverless/export/create.go
- internal/cli/serverless/export/create_test.go
- internal/cli/serverless/export/describe.go
- internal/cli/serverless/export/describe_test.go
- internal/cli/serverless/export/download.go
- internal/cli/serverless/export/download_with_prompt.go
- internal/cli/serverless/export/download_without_prompt.go
- internal/cli/serverless/export/export.go
- internal/cli/serverless/export/list.go
- internal/cli/serverless/export/list_test.go
- internal/cli/serverless/export/ui.go
- internal/cli/serverless/list.go
- internal/cli/serverless/list_test.go
- internal/cli/serverless/migration/create.go
- internal/cli/serverless/migration/create_test.go
- internal/cli/serverless/migration/delete.go
- internal/cli/serverless/migration/delete_test.go
- internal/cli/serverless/migration/describe.go
- internal/cli/serverless/migration/describe_test.go
- internal/cli/serverless/migration/list.go
- internal/cli/serverless/migration/list_test.go
- internal/cli/serverless/migration/migration.go
- internal/cli/serverless/migration/pause.go
- internal/cli/serverless/migration/pause_test.go
- internal/cli/serverless/migration/resume.go
- internal/cli/serverless/migration/resume_test.go
- internal/cli/serverless/migration/template.go
- internal/cli/serverless/migration/template_test.go
- internal/cli/serverless/privatelink/attach.go
- internal/cli/serverless/privatelink/create.go
- internal/cli/serverless/privatelink/delete.go
- internal/cli/serverless/privatelink/describe.go
- internal/cli/serverless/privatelink/detach.go
- internal/cli/serverless/privatelink/list.go
- internal/cli/serverless/privatelink/privatelink.go
- internal/cli/serverless/privatelink/ui.go
- internal/cli/serverless/privatelink/zone.go
- internal/cli/serverless/region.go
- internal/cli/serverless/restore.go
- internal/cli/serverless/restore_test.go
- internal/cli/serverless/shell.go
- internal/cli/serverless/spending_limit.go
- internal/cli/serverless/spending_limit_test.go
- internal/cli/serverless/sqluser/create.go
- internal/cli/serverless/sqluser/create_test.go
- internal/cli/serverless/sqluser/delete.go
- internal/cli/serverless/sqluser/delete_test.go
- internal/cli/serverless/sqluser/list.go
- internal/cli/serverless/sqluser/list_test.go
- internal/cli/serverless/sqluser/sqluser.go
- internal/cli/serverless/sqluser/update.go
- internal/cli/serverless/sqluser/update_test.go
- internal/cli/serverless/update.go
- internal/cli/serverless/update_test.go
- internal/cli/upgrade/upgrade.go
- internal/cli/version/version.go
- internal/config/config.go
- internal/config/profile.go
- internal/config/profile_test.go
- internal/config/store/keyring.go
- internal/config/store/keyring_darwin.go
- internal/config/store/keyring_linux.go
- internal/config/store/keyring_windows.go
- internal/flag/flag.go
- internal/helper.go
- internal/iostream/iostream.go
- internal/log/logger.go
- internal/output/output.go
- internal/prop/property.go
- internal/service/aws/s3/default_read_seeker_write_to.go
- internal/service/aws/s3/default_read_seeker_write_to_windows.go
- internal/service/aws/s3/pool.go
- internal/service/aws/s3/uploader.go
- internal/service/cloud/api_client.go
- internal/service/cloud/logic.go
- internal/service/github/version.go
- internal/telemetry/command.go
- internal/telemetry/event.go
- internal/telemetry/event_test.go
- internal/telemetry/installer_darwin.go
- internal/telemetry/installer_linux.go
- internal/telemetry/installer_windows.go
- internal/telemetry/sender.go
- internal/telemetry/telemetry.go
- internal/telemetry/tracker.go
- internal/telemetry/tracker_test.go
- internal/ui/chat_box_model.go
- internal/ui/common.go
- internal/ui/confirm_model.go
- internal/ui/process_model.go
- internal/ui/select_model.go
- internal/ui/spinner_model.go
- internal/ui/text_area_model.go
- internal/ui/text_input_model.go
- internal/util/arg.go
- internal/util/authorized_network.go
- internal/util/browser.go
- internal/util/constant.go
- internal/util/download.go
- internal/util/error.go
- internal/util/search.go
- internal/util/shell.go
- internal/util/sqluser.go
- internal/util/test.go
- internal/util/toml.go
- internal/util/validation.go
- internal/util/wordwrap.go
- internal/util/wordwrap_test.go
- internal/version/version.go
- scripts/add-copy.sh
- scripts/fix-lint.sh
- scripts/fmt.sh
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds binlog filter support to the TiDB Cloud migration API. The feature allows users to specify global filtering rules for binlog events and SQL patterns during incremental replication, enabling more fine-grained control over what data changes are migrated.
Changes:
- Added new
BinlogFilterRulemodel withignoreEventandignoreSqlfields for filtering binlog events and SQL patterns - Updated
MigrationServicePrecheckBody,MigrationServiceCreateMigrationBody, andMigrationmodels to include optionalBinlogFilterRulefield - Enhanced CLI templates and implementation to support binlog filter configuration in migration creation and precheck operations
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/tidbcloud/v1beta1/serverless/migration/model_binlog_filter_rule.go | New model defining binlog filter rules with ignoreEvent and ignoreSql arrays |
| pkg/tidbcloud/v1beta1/serverless/migration/model_migration_service_precheck_body.go | Added optional BinlogFilterRule field with getter/setter methods and JSON serialization support |
| pkg/tidbcloud/v1beta1/serverless/migration/model_migration_service_create_migration_body.go | Added optional BinlogFilterRule field with getter/setter methods and JSON serialization support |
| pkg/tidbcloud/v1beta1/serverless/migration/model_migration.go | Added optional BinlogFilterRule field with getter/setter methods and JSON serialization support |
| pkg/tidbcloud/v1beta1/serverless/migration/api/openapi.yaml | Added BinlogFilterRule schema definition and integrated it into migration-related schemas |
| pkg/tidbcloud/v1beta1/serverless/migration/README.md | Added BinlogFilterRule to documentation model list |
| pkg/tidbcloud/v1beta1/serverless/migration/.openapi-generator/FILES | Updated file list to include model_binlog_filter_rule.go |
| pkg/tidbcloud/v1beta1/serverless/dm.swagger.json | Added BinlogFilterRule definition and integrated into migration schemas; reformatted enum arrays for consistency |
| internal/cli/serverless/migration/template.go | Added example binlog filter configuration with comments in migration templates |
| internal/cli/serverless/migration/create_test.go | Added test case to verify binlog filter rule parsing and validation |
| internal/cli/serverless/migration/create.go | Updated parseMigrationDefinition to parse and return binlog filter rule; integrated binlogFilterRule into precheck and create flows |
| .gitignore | Added .gomodcache/ and .gocache/ entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.