This repository was archived by the owner on Jul 7, 2025. It is now read-only.
fix: Don't try to revoke a token that has already expired#109
Open
wwsean08 wants to merge 1 commit intotibdex:mainfrom
Open
fix: Don't try to revoke a token that has already expired#109wwsean08 wants to merge 1 commit intotibdex:mainfrom
wwsean08 wants to merge 1 commit intotibdex:mainfrom
Conversation
shukiscopio
approved these changes
May 3, 2024
seanelsayed-zh
approved these changes
Oct 22, 2024
|
Closes #111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to fix when a CI job fails because it tries to revoke a token which has already expired. Given that github provides the expiration time, it's worth referencing that and preventing the error in the first place.
Testing
This was tested using an internal repostiory, below are the workflow files and the results:
Skipping revoke as it's expired
Revoking as it's not expired