feat(web): add color theme presets#1040
Open
NightWatcher314 wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Findings
None.
Summary
Review mode: initial
No high-confidence issues found in the added/modified lines. Residual risk: review was limited to static inspection of the web theme/color changes and related initialization paths.
Testing
Not run (automation review; did not execute PR code).
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation notes
This supersedes #964 with a fresh branch based on current
main, after the responsive settings redesign in #1027. It preserves the fixes from the earlier bot review:theme-colorsynchronizationOLED intentionally uses each preset's dark palette while retaining OLED as a separate appearance option when the default palette is selected.
Validation
bun typecheckbun run build:webmarkdown-a.test.tsx: jsdom rejects Bun's experimentallocalStorageasStorageEvent.storageArea; unrelated targeted rerun reproduces it on upstream codeCloses #963