Update favicons for light and dark modes

[davinotdavid]

Light mode (active tab):

Light mode (inactive tab):

Dark mode (active tab):

Dark mode (inactive tab):

Changed per Design team request, based off of these Figma files. Title has already been changed!

Closes #1820

[rwood-moz]

Hey @davinotdavid, when I try out the branch locally, the Appointment tab (active or inactive) only always shows in light mode. If I set my Firefox browser settings to Dark mode, or I set the Appointment theme settings to Dark mode, the browser tab still remains in light mode. Is this working for you?

[rwood-moz]

Hey @davinotdavid, when I try out the branch locally, the Appointment tab (active or inactive) only always shows in light mode. If I set my Firefox browser settings to Dark mode, or I set the Appointment theme settings to Dark mode, the browser tab still remains in light mode. Is this working for you?

Oh wait, I see when I change my overall MacBook Apple theme to Dark mode then the Appointment tab does change into dark mode (active or inactive tab). Is that the expected behaviour? Are there plans to implement this at the Browser level or Appointment theme level too, or just System level for now?

[davinotdavid]

Oh wait, I see when I change my overall MacBook Apple theme to Dark mode then the Appointment tab does change into dark mode (active or inactive tab). Is that the expected behaviour? Are there plans to implement this at the Browser level or Appointment theme level too, or just System level for now?

Ah, part of #1821 will be to actually remove the user setting of theme within Appointment altogether (will make a note for me to remember to remove the tests related to it), in favor of device settings first + toggle in the navbar itself.

The browser level / user agent should work though 🤔 . I wonder if this is a Firefox bug of sorts? We are using the standard prefers-color-scheme API to switch the colours on it.

[devmount]

I tested this in Firefox and Helium on Tuxedo OS with both, dark and light mode settings in the browser. Perfectly working fine on my end.

[rwood-moz]

Ok I see the issue - but it's a Firefox/Mac issue, not an Appointment issue. FYI I'm on MacBook M3 Pro Tahoe 26, with latest Firefox 156.0.

The issue is that when I change the Firefox browser setting to dark mode, the browser tabs themselves do NOT change to dark mode.

Screenshot with Firefox browser light mode:

Screenshot with Firefox browser settings set to dark, notice the tabs remain light:

For my Firefox, the only way to get the browser tabs themselves to change to dark mode is to change the Apple system theme setting:

So this is not an Appointment issue since it happens with all the tabs.

[davinotdavid]

Thanks @rwood-moz and @devmount for the great testing / reviews! 🙏