Repository navigation
Pin JSON < 3 for older Rails to fix quirks_mode - #3073
Merged
Merged
Conversation
nickcharlton
force-pushed
the
nc-pin-json-below-3-for-older-rails
branch
from
October 21, 2026 10:38
0dc9095 to
c0c02a8
Compare
As we try and upgrade Node to v24.19.0 in #3058, we started getting a whole bunch of errors around `quirks_mode`. This seems to be due to a change in JSON, where 3.0.2 no longer passes the `quirks_mode` keyword as part of some serialisation routine. rails/solid_queue#813
nickcharlton
force-pushed
the
nc-pin-json-below-3-for-older-rails
branch
from
October 21, 2026 10:46
c0c02a8 to
55c37f0
Compare
nickcharlton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we try and upgrade Node to v24.19.0 in #3058, we started getting a whole bunch of errors around
quirks_mode. This seems to be due to a change in JSON, where 3.0.2 no longer passes thequirks_modekeyword as part of some serialisation routine.rails/solid_queue#813