chore(storage): add storage benchmark tool for Gaxios refactor comparison#16
Open
thiyaguk09 wants to merge 19 commits into
Open
chore(storage): add storage benchmark tool for Gaxios refactor comparison#16thiyaguk09 wants to merge 19 commits into
thiyaguk09 wants to merge 19 commits into
Conversation
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
…otprint against baseline versions
thiyaguk09
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new benchmarking tool and documentation to compare the current library's performance against a baseline NPM version, focusing on latency and memory usage for common operations. Feedback highlights a critical command injection vulnerability in the baseline installation process and notes that the provided project ID is currently ignored during storage initialization. Other recommendations include improving type safety, ensuring temporary directory and cloud resource cleanup, handling edge cases for zero iterations, and setting non-zero exit codes on failure for better CI integration.
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
72c17d7 to
eacb087
Compare
thiyaguk09
changed the title
…4856049-gaxios-benchmark
…4856049-gaxios-benchmark
thiyaguk09
changed the title
…xible module resolution
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
eacb087 to
0c58a9a
Compare
…4856049-gaxios-benchmark
…4856049-gaxios-benchmark
…d resumable uploads while updating transport retry defaults
…sport (googleapis#8283) - Remove Service.ts and common.ts files from handwritten/storage - Migrate remaining functionality to StorageTransport - chore(ci): upgrade conformance tests to Node 18
thiyaguk09
force-pushed
the
storage-node-18
branch
from
0c58a9a to
fe44861
Compare
…4856049-gaxios-benchmark
thiyaguk09
force-pushed
the
storage-node-18
branch
from
fe44861 to
0a4f5ac
Compare
…4856049-gaxios-benchmark
…, and list files scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕