fix(storage): Invocation ID is not retained on multipart upload retries#11
Open
thiyaguk09 wants to merge 2 commits into
Open
fix(storage): Invocation ID is not retained on multipart upload retries#11thiyaguk09 wants to merge 2 commits into
thiyaguk09 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily updates dependency versions in the manifest file, adds 'prettier' to the Bazel build dependencies, and applies extensive formatting and cleanup changes across several generated TypeScript client files. These changes include standardizing import styles, improving type definitions, and refining internal method implementations for consistency. As there were no review comments provided, I have no specific feedback to offer.
thiyaguk09
force-pushed
the
storage-node-18
branch
from
b4ee48b to
b2e12e7
Compare
Hoists the generation of `persistentInvocationId` to the beginning of the upload process in `Bucket.upload` and `File.save`. This ensures that retried multipart upload attempts reuse the same invocation ID in the `x-goog-api-client` header, rather than generating a new one for each attempt.
thiyaguk09
force-pushed
the
fix/multipart-invocation-id
branch
from
5b69a10 to
e232f4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕