Skip to content

sink: guard against zero frame size in free-frames #10937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lgirdwood wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

sink: guard against zero frame size in free-frames #10937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/module/audio/sink_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,15 @@ EXPORT_SYMBOL(sink_get_frame_bytes);

size_t sink_get_free_frames(struct sof_sink *sink)
{
return sink_get_free_size(sink) / sink_get_frame_bytes(sink);
size_t frame_bytes = sink_get_frame_bytes(sink);

/* frame_bytes is channels * sample_size and both are host-influenced;
* guard against a zero divisor (e.g. channels == 0)
*/
if (!frame_bytes)
return 0;

return sink_get_free_size(sink) / frame_bytes;
}
EXPORT_SYMBOL(sink_get_free_frames);

Expand Down
Loading