Skip to content

Add vale check for capitalization of "Pulp Manifest"#4875

Merged
maximiliankolb merged 2 commits into
theforeman:masterfrom
ATIX-AG:vale_pulp_manifest
May 27, 2026
Merged

Add vale check for capitalization of "Pulp Manifest"#4875
maximiliankolb merged 2 commits into
theforeman:masterfrom
ATIX-AG:vale_pulp_manifest

Conversation

@maximiliankolb

@maximiliankolb maximiliankolb commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What changes are you introducing?

  • Capitalize "Pulp Manifest"
  • Add vale check to enforce correct capitalization of "Pulp Manifest"

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Refs #4864 (comment)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.19/Katello 4.21
  • Foreman 3.18/Katello 4.20 (Satellite 6.19)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels May 22, 2026
@maximiliankolb maximiliankolb changed the title Vale pulp manifest Add vale check for capitalization of "Pulp Manifest" May 22, 2026
maximiliankolb
maximiliankolb commented May 22, 2026
View reviewed changes
Comment thread .vale/styles/foreman-documentation/Capitalization.yml
@github-actions

github-actions Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

The PR preview for 77ff5d5 is available at theforeman-foreman-documentation-preview-pr-4875.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

aneta-petrova
aneta-petrova reviewed May 25, 2026
View reviewed changes
Comment thread .vale/styles/foreman-documentation/Capitalization.yml Outdated
Comment thread .vale/styles/foreman-documentation/Capitalization.yml
maximiliankolb
maximiliankolb commented May 26, 2026
View reviewed changes

@maximiliankolb maximiliankolb left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lena and Anet. Ready for review.

@maximiliankolb maximiliankolb removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels May 26, 2026
@maximiliankolb maximiliankolb mentioned this pull request May 26, 2026
Merged
10 tasks
@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels May 26, 2026
@maximiliankolb maximiliankolb merged commit d95c628 into theforeman:master May 27, 2026
11 checks passed
@maximiliankolb maximiliankolb deleted the vale_pulp_manifest branch May 27, 2026 05:42
maximiliankolb added a commit that referenced this pull request May 27, 2026
@maximiliankolb
Add vale check for capitalization of "Pulp Manifest" (#4875)
135c1db 
* Capitalize Pulp Manifest
* Add vale rule to always capitalize Pulp Manifest

Refs #4864

(cherry picked from commit d95c628)
maximiliankolb added a commit that referenced this pull request May 27, 2026
@maximiliankolb
Add vale check for capitalization of "Pulp Manifest" (#4875)
2a9da7e 
* Capitalize Pulp Manifest
* Add vale rule to always capitalize Pulp Manifest

Refs #4864

(cherry picked from commit d95c628)
@maximiliankolb

maximiliankolb commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

Merged to "master" and cherry-picked:
068fb6a..135c1db 3.19 -> 3.19
afb0f9d..2a9da7e 3.18 -> 3.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lennonka Lennonka Lennonka left review comments

@aneta-petrova aneta-petrova aneta-petrova approved these changes

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maximiliankolb @aneta-petrova @Lennonka