Repository navigation
Conversation
Use iconForContentType: with UTTypeData for Git-deleted entries, matching the existing generic-file fallback. On the tested macOS, the legacy HFS lookup draws no document icon; the modern lookup restores it while retaining the deletion badge. Refs #118
Author
|
Hi @dayglojesus , thanks! I think that the dimmed version is the way to go I close here as superseded by #129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
Draft pending maintainer confirmation of the deleted-entry glyph. This replaces the legacy empty/dashed missing-object placeholder with a generic document icon. Please confirm that this visual change is appropriate before marking the PR ready.
Use
-[NSWorkspace iconForContentType:UTTypeData]for the deleted-state icon inFrameworks/TMFileReference/src/TMFileReference.mm, replacing the deprecated HFS-basediconForFileType:lookup.One line, reusing the generic-file fallback and UniformTypeIdentifiers import/link already present in the same class. Git status handling, red deletion badge, caching, modified opacity and callers are unchanged. Deleted entries remain generic rather than extension-specific.
This is not a pixel-equivalent API substitution or a claim that the old lookup returns no image. The old missing-object outline is visible in light mode and faint in dark mode; the proposal draws a document with the same red badge. The screenshots below show that tradeoff.
Refs #118: one of the six deprecated icon lookup sites, not the complete icon-family migration. Independent of #122–#125.
Before and after
Actual built app, same synthetic Git project and 1040×680-point viewport. Six deleted file types:
.txt,.md,.py,.json,.pngand no extension. Added, modified and unchanged files provide controls.4fc23bc6870f42d3Captures contain synthetic data only, were optimized with
optipng -quiet, and are attached rather than committed. Images are hosted against the contributor's public fork. The previous app/session and macOS appearance were restored after capture; no installed app or user project was modified.Verification
Local checks on Apple Silicon, macOS 27.0.1:
iconForFileType:warning.FileBrowserandOakTabBarViewsuites: both pass before and after.git diff --check: passed.The probe constructs its expected image using the corresponding background API, so screenshots establish the actual glyph. The full project suite, other macOS versions and a contributor-performed functional regression test were not run. Local checks are not remote CI results.
Independent review
Read-only Pi review of
870f42d3through Anthropic directly: no introduced blockers. The reviewer traced the class, SCM providers/consumers, existing type/linking convention, SDK availability, probes and original screenshots. The API is available since macOS 11, below the 14.0 deployment target. They executed no verification and did not review the later six-type/light-mode captures; the source and reviewed diff are unchanged.Prepared with AI assistance. Please independently review both the migration and the proposed visual policy. This code-only review is not a CI-backed merge approval.
AI reviewer: anthropic/claude-opus-5-5 · reasoning: high