Skip to content

refactor: Remove download quality message from action sheets #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Balamurugan-Testpress merged 1 commit into from
Mar 17, 2026
Merged

refactor: Remove download quality message from action sheets #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Database/TPStreamsDownloadManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public final class TPStreamsDownloadManager {
on viewController: UIViewController,
completion: ((Result<OfflineAsset, TPDownloadError>) -> Void)?
) {
let alert = UIAlertController(title: "Select Download Quality", message: "Video quality adjusts based on your internet speed. Your selection sets the highest possible quality.", preferredStyle: .actionSheet)
let alert = UIAlertController(title: "Select Download Quality", message: nil, preferredStyle: .actionSheet)

for quality in qualities {
alert.addAction(UIAlertAction(title: quality.resolution, style: .default) { _ in
Expand Down
2 changes: 1 addition & 1 deletion Source/Views/SwiftUI/PlayerSettingsButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ struct PlayerSettingsButton: View {
case .downloadQuality:
return ActionSheet(
title: Text("Download Quality"),
message: Text("Video quality adjusts based on your internet speed. Your selection sets the highest possible quality."),
message: nil,
buttons: downloadQualityOptions() + [.cancel()]
)
}
Expand Down
2 changes: 1 addition & 1 deletion Source/Views/UIKit/PlayerControlsUIView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class PlayerControlsUIView: UIView {
}

func createDownloadQualityMenu() -> UIAlertController {
let qualityMenu = UIAlertController(title: "Available resolutions", message: "Video quality adjusts based on your internet speed. Your selection sets the highest possible quality.", preferredStyle: ACTION_SHEET_PREFERRED_STYLE)
let qualityMenu = UIAlertController(title: "Available resolutions", message: nil, preferredStyle: ACTION_SHEET_PREFERRED_STYLE)
var availableVideoQualities = player.availableVideoQualities
// Remove Auto Quality from the Array
availableVideoQualities.remove(at: 0)
Expand Down
Loading