feat: Show total contents on course cards#43
feat: Show total contents on course cards#43Gowreesh-A-M wants to merge 2 commits intofeat/integrate-course-listfrom
Conversation
Gowreesh-A-M
commented
Mar 22, 2026
- Show content counts instead of duration on the Study tab.
- Fix API mapping for contents_count and add a DB migration.
- Link Explore stubs to mock data for a complete dashboard view.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the user experience by replacing approximate course durations with a precise count of learning contents on course cards. This change involves comprehensive updates across the data layer, including API mapping, database schema migration, and UI adjustments, to ensure accuracy and provide users with more meaningful information about course volume. Additionally, it enhances the development environment by integrating mock data for various explore features. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the course cards from displaying duration to showing the total number of contents. The changes span across the data model, database schema with a proper migration, API data mapping, and UI components. The use of mock data for the Explore stubs is also a good step for development.
I've provided a few suggestions to improve code robustness and maintainability:
- Decoupling
HttpDataSourcefromMockDataSource. - Making the JSON parsing in
RemoteCourseDtosafer against potential type mismatches from the API. - Implementing proper pluralization for UI strings to enhance the user experience.
Overall, this is a solid feature implementation.
e4558a7 to
0ef834d
Compare
- Fix API mapping to use 'contents_count' with robust num parsing. - Migrate Study cards from duration to localized content counts. - Implement proper pluralization support for chapters and contents. - Restore original behavior for Profile and Explore tabs.
5337de6 to
42b76a6
Compare